Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish translation update #441

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

Greg-21
Copy link
Contributor

@Greg-21 Greg-21 commented Aug 30, 2024

In this pull request, I updated the Polish translation to include all the changes to the source translation strings made since my last update of the Polish translation 2 years ago in commit a52e7ee. I also took the opportunity to improve some of the existing text strings to ensure the highest possible standards of the translations I maintain.

TheIllusiveC4, could you please tell me what other branches you still support so that I know where to backport this translation if it gets accepted in the main branch?

@TheIllusiveC4 TheIllusiveC4 self-assigned this Oct 24, 2024
@TheIllusiveC4 TheIllusiveC4 added type: localization status: confirmed This issue or pull request has been accepted labels Oct 24, 2024
@TheIllusiveC4
Copy link
Owner

Thank you!

As for the other branches, I can merge your changes into the 1.20.1 branch as well but that's something I can do on my own without needing another PR.

@TheIllusiveC4 TheIllusiveC4 merged commit 3690859 into TheIllusiveC4:1.20.6 Oct 24, 2024
@Greg-21
Copy link
Contributor Author

Greg-21 commented Oct 24, 2024

It would be great if you could do that. Thank you! Just please note that version 1.20.1 is from before the networking overhaul designed by Modmuss50, so the curios.networking.failed translation key is unnecessary in that version. Everything else should be fine, though.

And by the way, do you also support 1.19.2 by any chance (which still seems to be very popular among modded Minecraft players)? The last mod update for that version was just a few months ago, on July 2, 2024. If you're interested, I can take care of it since there are a few more differences in the source translation strings between 1.20.1 and 1.19.2. But if you're not, that's totally understandable but a bit unfortunate.

EDIT: Actually, I've already done the above in PR #451 in the meantime. Feel free to close it if you don't plan on releasing any updates for that version, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: confirmed This issue or pull request has been accepted type: localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants