Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pt_br.json to the latest version #265

Merged
merged 3 commits into from
Dec 8, 2022

Conversation

FITFC
Copy link

@FITFC FITFC commented Oct 29, 2022

No description provided.

src/main/resources/assets/curios/lang/pt_br.json Outdated Show resolved Hide resolved
"curios.identifier.curio": "Raridade",
"argument.entity.options.curios.description": "Inventário do curios da entidade",
"argument.curios.type.unknown": "Tipo de slot de Curio desconhecido %s",
"curios.identifier.curio": "Curio",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the correct translation should be here, but this slot is supposed to be "curio" as in "accessory" or something else suitably generic. It's meant to be a very non-specific type of slot. It's not just the name of the mod. It works in English as-is but it should probably be translated in order to get across the actual meaning. But I don't know if "Curio" also happens to work in Portuguese, so just let me know one way or the other.

"curios.modifiers.curio": "Quando usado como raridade:",
"curios.modifiers.necklace": "Quando em volta do pescoço:",
"curios.modifiers.ring": "Quando usado como anel:",
"curios.modifiers.curio": "Quando usado no Curio:",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment above about the semantics of the curio slot also applies here.

@TheIllusiveC4
Copy link
Owner

The main thing left to resolve is my comments about the meaning of "Curio" in your translation. The slot identifier should translate to something generic like "Accessory". Since you just left it as Curio, the same as in English, I would need to know if that actually is translated properly.

@TheIllusiveC4
Copy link
Owner

Thanks!

@TheIllusiveC4 TheIllusiveC4 merged commit e835a2e into TheIllusiveC4:1.18.x Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants