Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A way to make piglins neutral towards player wearing the accessory #86

Closed
Aizistral opened this issue Nov 4, 2020 · 0 comments
Closed
Assignees
Labels
type: enhancement New feature or request

Comments

@Aizistral
Copy link
Contributor

Aizistral commented Nov 4, 2020

Please describe the new feature or change.
Basically the same thing in ICurio as makesPiglinsNeutral method allows to pull off in IForgeItem.

Please describe why you want this feature.
I saw many people have wanted to make/use accesories that would've rendered piglins neutral, similar to how wearing gold armor does, but while making armor with such trait is as simple as overriding the abovementioned method for item in question, there doesn't seem to be any explicit hooks to do this for anything else, and I spent a significant amount of time looking. For reasons beyound by guessing, piglins don't even have LivingSetAttackTargetEvent fired for them at the moment.

For anyone interested, this should be possible with the use of Mixin and I wanted to make pull request on the matter myself, but as @TheIllusiveC4 stated on Discord:

I'm not against the idea itself; however, the problem with using mixins in Forge is that mods that use Curios as a library have to explicitly disable the refmap in their program arguments, which adds an additional layer of complexity to dependent project setup.

It was therefore decided to put this feature on hold until either this inconvenience is rectified on the side of Forge, or there are reasons more significant to use Mixin in Curios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants