Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translations of South African languages #290

Open
ghalse opened this issue Nov 14, 2024 · 3 comments
Open

Missing translations of South African languages #290

ghalse opened this issue Nov 14, 2024 · 3 comments

Comments

@ghalse
Copy link

ghalse commented Nov 14, 2024

Two years ago contributed translations for four South African languages (PR #235). While that pull request was merged, somewhere along the line those translations have been lost from the released versions and don't appear in the staging branch.

We're preparing to go through a new translation cycle early next year, and I'll happily include any now-missing strings in that cycle. However, I'm only going to do that if the translations are actually used.

Is it possible to work out what's needed to restore these? And if there's a reason why they went missing, to let us know (so we don't bother trying to maintain them).

@sunetzacharias
Copy link
Contributor

sunetzacharias commented Nov 14, 2024 via email

@ghalse
Copy link
Author

ghalse commented Nov 19, 2024

We have worked through the translations, and these might be broken.

Broken in what way? I'd happily have fixed them if I knew what needed to be fixed.

@enriquepablo
Copy link
Contributor

It is weird. The PR was apparently merged on 19th August 2022, but the commit history does not show that entry for that date.
At this point there are a few more translatable strings, you can check them at:

https://github.com/TheIdentitySelector/thiss-js/blob/staging/src/assets/translations/en.json

I can recover the code from the PR and commit it myself mentioning you as contributor, and then you can add the missing translations, or you can first complete the translation and then open a new PR. Tell me what you'd like, if the latter, this is were the language selector is located at this time:

https://github.com/TheIdentitySelector/thiss-js/blob/staging/src/ds/index.ejs#L119

Ping me if you have any doubt about the intent of any of the messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants