-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing translations of South African languages #290
Comments
We have worked through the translations, and these might be broken. We will
include the ones we have and happily take an updated version at a later
stage.
…On Thu, 14 Nov 2024 at 15:40, Guy Halse ***@***.***> wrote:
Two years ago contributed translations for four South African languages
(PR #235 <#235>).
While that pull request was merged, somewhere along the line those
translations have been lost from the released versions and don't appear in
the staging branch.
We're preparing to go through a new translation cycle early next year, and
I'll happily include any now-missing strings in that cycle. However, I'm
only going to do that if the translations are actually used.
Is it possible to work out what's needed to restore these? And if there's
a reason why they went missing, to let us know (so we don't bother trying
to maintain them).
—
Reply to this email directly, view it on GitHub
<#290>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2SU6EH6YAUDRZ5NY65JUID2ASY7DAVCNFSM6AAAAABRZB3XM2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGY2TSMBTGU4DKMY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Broken in what way? I'd happily have fixed them if I knew what needed to be fixed. |
It is weird. The PR was apparently merged on 19th August 2022, but the commit history does not show that entry for that date. https://github.com/TheIdentitySelector/thiss-js/blob/staging/src/assets/translations/en.json I can recover the code from the PR and commit it myself mentioning you as contributor, and then you can add the missing translations, or you can first complete the translation and then open a new PR. Tell me what you'd like, if the latter, this is were the language selector is located at this time: https://github.com/TheIdentitySelector/thiss-js/blob/staging/src/ds/index.ejs#L119 Ping me if you have any doubt about the intent of any of the messages. |
Two years ago contributed translations for four South African languages (PR #235). While that pull request was merged, somewhere along the line those translations have been lost from the released versions and don't appear in the staging branch.
We're preparing to go through a new translation cycle early next year, and I'll happily include any now-missing strings in that cycle. However, I'm only going to do that if the translations are actually used.
Is it possible to work out what's needed to restore these? And if there's a reason why they went missing, to let us know (so we don't bother trying to maintain them).
The text was updated successfully, but these errors were encountered: