Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HIBP Analyzer with templates #367

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

crackytsi
Copy link
Contributor

Added HIBP Analyzer with templates

@arnydo
Copy link
Contributor

arnydo commented Nov 27, 2018

This is excellent! Hopefully it gets merged soon. It will be a great addition to Phishing email investigations.

Copy link
Contributor

@arnydo arnydo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have found that it may be useful to allow the option for including unverified breaches. Search All Breaches.

"By default, only verified breaches are returned when performing a search."

analyzers/HIBP_Query/HIBP_Query.json Show resolved Hide resolved
analyzers/HIBP_Query/hibpquery_analyzer.py Show resolved Hide resolved
analyzers/HIBP_Query/hibpquery_analyzer.py Show resolved Hide resolved
@nadouani nadouani added this to the 1.15.0 milestone Nov 29, 2018
@nadouani nadouani merged commit 60593ec into TheHive-Project:develop Nov 29, 2018
@nadouani
Copy link
Contributor

@arnydo Looks like your changes were not included in the PR, can you please submit the PR on top of the latest develop branch so I can accept it? Thanks

@arnydo
Copy link
Contributor

arnydo commented Nov 29, 2018

Yes sir! Thank you.

@nadouani
Copy link
Contributor

@arnydo do you think you can make it today, or should I switch on something else until you submit the changes?

@arnydo
Copy link
Contributor

arnydo commented Nov 29, 2018

@nadouani Just sent the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-analyzer New analyzer submitted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants