Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: PEP8 all the things #165

Merged
merged 1 commit into from
Mar 6, 2018
Merged

WIP: PEP8 all the things #165

merged 1 commit into from
Mar 6, 2018

Conversation

3c7
Copy link
Contributor

@3c7 3c7 commented Jan 10, 2018

No description provided.

@3c7 3c7 added the category:enhancement Issue is related to an existing feature to improve label Jan 10, 2018
@3c7 3c7 self-assigned this Jan 10, 2018
@3c7 3c7 requested review from nadouani and jeromeleonard January 10, 2018 08:00
nadouani
nadouani approved these changes Jan 10, 2018
View reviewed changes
analyzers/CuckooSandbox/cuckoosandbox_analyzer.py
@@ -26,10 +26,10 @@ def summary(self, raw):

result = {
'service': self.service,
'dataType': self.data_type
'dataType': self.data_type,
'malscore': raw.get('malscore', None),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PEP8 related?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forget about it :)

@nadouani
Copy link
Contributor

This looks fine for me, you can merge it

@To-om To-om merged commit bf2f5e2 into TheHive-Project:develop Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadouani nadouani nadouani approved these changes

@jeromeleonard jeromeleonard Awaiting requested review from jeromeleonard

Assignees

@3c7 3c7

Labels
category:enhancement Issue is related to an existing feature to improve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@3c7 @nadouani @To-om