Fixes #286: Correct handling of ssl parameter

analyzers/MISP/mispclient.py

@@ -44,21 +44,18 @@ def __init__(self, url, key, ssl=True, name='Unnamed', proxies=None):
                 if isinstance(ssl, list):
                     if isinstance(ssl[idx], str) and os.path.isfile(ssl[idx]):
                         verify = ssl[idx]
-                    elif isinstance(ssl[idx], str) and not os.path.isfile(ssl[idx]):
+                    elif isinstance(ssl[idx], str) and not os.path.isfile(ssl[idx]) and ssl[idx] != "":
                         raise CertificateNotFoundError('Certificate not found under {}.'.format(ssl[idx]))
                     elif isinstance(ssl[idx], bool):
                         verify = ssl[idx]
-                    else:
-                        raise TypeError('SSL parameter is a not expected type: {}'.format(type(ssl[idx])))
+
                 # Do the same checks again, for the non-list type
                 elif isinstance(ssl, str) and os.path.isfile(ssl):
                     verify = ssl
-                elif isinstance(ssl, str) and not os.path.isfile(ssl):
+                elif isinstance(ssl, str) and not os.path.isfile(ssl) and ssl != "":
                     raise CertificateNotFoundError('Certificate not found under {}.'.format(ssl))
                 elif isinstance(ssl, bool):
                     verify = ssl
-                else:
-                    raise TypeError('SSL parameter is a not expected type: {}'.format(type(ssl)))
                 self.misp_connections.append(pymisp.PyMISP(url=server,
                                                            key=key[idx],
                                                            ssl=verify,
@@ -67,7 +64,7 @@ def __init__(self, url, key, ssl=True, name='Unnamed', proxies=None):
             verify = True
             if isinstance(ssl, str) and os.path.isfile(ssl):
                 verify = ssl
-            elif isinstance(ssl, str)and not os.path.isfile(ssl):
+            elif isinstance(ssl, str) and not os.path.isfile(ssl) and ssl != "":
                 raise CertificateNotFoundError('Certificate not found under {}.'.format(ssl))
             elif isinstance(ssl, bool):
                 verify = ssl