This repository has been archived by the owner on Aug 16, 2019. It is now read-only.
12 Fix bug deleting entities #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit: * Fixes a bug in which entities deleted by the server were not deleted in state. This happened when the server did not respond with the deleted entity’s ID, which is a likely scenario causing a bug in most cases. To delete an entity, dispatch the `destroy` thunk action passing in the entity to delete as the parameter. The entity to delete must have an `id` key.
mikestone14
commented
May 31, 2018
| const state = mockStore.getState(); | ||
|
|
||
| expect(destroySuccessAction.payload).toEqual({ data: { id: userStub.id } }); | ||
| expect(config.reducer(state, destroySuccessAction)).toEqual(store); |
There was a problem hiding this comment.
This is how to test the full reducer/thunk implementation using redux-mock-store. Since the mock store cannot be configured with reducers we need to explicitly call the reducer here.
More info here: reduxjs/redux-mock-store#71 (comment)
| @@ -107,6 +107,8 @@ class BaseConfig { | |||
| ...this._genericActions(TYPES.DESTROY), | |||
There was a problem hiding this comment.
Do we still need this, or is what you added below taking its place?
There was a problem hiding this comment.
We get a couple additional actions with this, and additions below override the necessary actions.
There was a problem hiding this comment.
oh okay. I figured i was missing something im trying to catch up with whats going on and also review lol
violet-graves
approved these changes
May 31, 2018
|
I concur with Jacques 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit:
This happened when the server did not respond with the deleted entity’s ID, which is a likely scenario causing a bug in most cases.
To delete an entity, dispatch the
destroythunk action passing in the entity to delete as the parameter. The entity to delete must have anidkey.closes #12