Change signature of load_library_permanently
#445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheDan64
requested changes
Sep 29, 2023
gavrilikhin-d
changed the title
try_load_library_permanentlyload_library_permanently
gavrilikhin-d
commented
Sep 30, 2023
Comment on lines
+175
to
+177
| pub fn load_visible_symbols() { | ||
| unsafe { LLVMLoadLibraryPermanently(std::ptr::null()) }; | ||
| } |
There was a problem hiding this comment.
I didn't find it anywhere in docs, but people from StackOverflow (and tests) say that passing nullptr as filename results in loading all the symbols visible inside program
gavrilikhin-d
commented
Sep 30, 2023
| /// Search through all previously loaded dynamic libraries for `symbol`. | ||
| /// | ||
| /// Returns an address of the symbol, if found | ||
| pub fn search_for_address_of_symbol(symbol: &str) -> Option<usize> { |
There was a problem hiding this comment.
We may use this to protect from running non-linked functions in jit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change signature of
load_library_permanentlyto be more self-describingRelated Issue
#443
How This Has Been Tested
cargo t --features llvm16-0Will it be overkill to load a real dll in test?
Breaking Changes
Signature change breaks existing code
Checklist