Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI segfaults on older LLVM versions #513

Closed
TheDan64 opened this issue Jul 2, 2024 · 5 comments · Fixed by hash-org/inkwell#2
Closed

CI segfaults on older LLVM versions #513

TheDan64 opened this issue Jul 2, 2024 · 5 comments · Fixed by hash-org/inkwell#2
Labels
Milestone

Comments

@TheDan64
Copy link
Owner

TheDan64 commented Jul 2, 2024

CI will segfault on older LLVM versions

@TheDan64 TheDan64 added the bug label Jul 2, 2024
@TheDan64 TheDan64 added this to the 0.5.0 milestone Jul 2, 2024
@TheDan64
Copy link
Owner Author

I've narrowed it down to LLVM versions 4-9, test_values.rs test_value_from_string test

@TheDan64
Copy link
Owner Author

This line, which makes sense:

f64_type.const_float_from_string(""). Need to see if there's some error handling from LLVM here that we're missing

@TheDan64
Copy link
Owner Author

LLVM does not appear to notify us of errors here :/

@TheDan64
Copy link
Owner Author

The LLVM method doesn't return a null ptr on error; the best we can do is maybe mark the wrapper as unsafe...

@TheDan64
Copy link
Owner Author

TheDan64 commented Jul 13, 2024

According to https://github.com/bugsnag/llvm/blob/79a45b8b272aadab6d8259ffae19903205a19c51/lib/Support/APFloat.cpp#L2588

an assert triggers on empty string, would be easy enough to check for but not nearly enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant