Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openstreetmap #959

Merged
merged 3 commits into from
Jul 9, 2018
Merged

openstreetmap #959

merged 3 commits into from
Jul 9, 2018

Conversation

chongma
Copy link
Collaborator

@chongma chongma commented Jul 3, 2018

No description provided.

@chongma chongma requested a review from stephanrauh July 3, 2018 12:49
@stephanrauh
Copy link
Collaborator

@TheCoder4eu Do we want to include this PR with BootsFaces 1.3.0? If so, I could run a test tomorrow evening. What's your opinion?

BTW, the PR TheCoder4eu/BootsFacesWeb#56 also belongs to this change.

@chongma Did you modify the BootsFaces.jsfdsl, too? If not, we should copy the changes into that file, too, because it generates all the boilerplate code of the component and the documentation.

@chongma
Copy link
Collaborator Author

chongma commented Jul 6, 2018

@stephanrauh no, i did notice the BootsFaces.jsfdsl but wasn't sure it was being used. i just copied and edited the documentation from another component. i will take a look

@stephanrauh
Copy link
Collaborator

Thanks! The DSL generates the two component classes, a renderer skeleton, the *Attributes.xhtml files of the documentation, the taglib, and it even updates the ComponentsEnum class. It saves a lot of work (after installing the Xtext plugin and accepting that Eclipse is the only IDE you can use).

@stephanrauh stephanrauh requested a review from TheCoder4eu July 9, 2018 20:09
@TheCoder4eu TheCoder4eu merged commit 0d9c635 into TheCoder4eu:master Jul 9, 2018
@stephanrauh
Copy link
Collaborator

@chongma Awesome component! Just one attribute puzzles me. What does urlTemplate do?

@chongma
Copy link
Collaborator Author

chongma commented Jul 10, 2018

Openstreetmap loads "tiles" which are the squares of map it shows depending on the zoom level. As it is an open platform anyone can host these tiles. So URL template allows you to set the location of the tile provider. We should probably put a note in the documentation that if you abuse the tile provider by using too much bandwidth you will get banned. And if you are a heavy user you need to get permission from the tile provider

@TheCoder4eu TheCoder4eu added this to the v1.3.0 milestone Jul 14, 2018
@chongma
Copy link
Collaborator Author

chongma commented Jul 19, 2018

@stephanrauh maybe we could get listed on this page https://wiki.openstreetmap.org/wiki/Deploying_your_own_Slippy_Map under "Embedding OSM in a CMS/framework"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants