Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NotBlank annotation #739

Merged
merged 1 commit into from
Apr 28, 2017
Merged

Add support for NotBlank annotation #739

merged 1 commit into from
Apr 28, 2017

Conversation

NicolaIsotta
Copy link
Contributor

Fix #738

@NicolaIsotta
Copy link
Contributor Author

Clean diff: deac4d6?w=1

@ggam
Copy link
Collaborator

ggam commented Apr 28, 2017

Nice! A more robust way to do it would be to check the exact class name, no? If you choose this approach, please keep in mind that there's a new @notblank constrainr on Bean Validation 2.0 that would also need to he checked.

@stephanrauh
Copy link
Collaborator

There are pros for and cons against checking the exact class name. At the time being, I opt for flexibility. Most likely it's useless, but I render it unlikely that there are disadvantages.

@stephanrauh stephanrauh merged commit 417c62d into TheCoder4eu:master Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants