Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase performance of b:tree control #708

Merged
merged 2 commits into from
Apr 15, 2017

Conversation

PokimonZerg
Copy link
Contributor

  • Disable node serialization. At now, we don't send serialized node data to the client. Because it decrease performance and have no sense. Previos realization do nothing with this data.
  • We send nodeInternalId back from client. So, we can find actual node by this id.
  • Pass [] empty array in case there b:tree has no value. (More natural then throwing an exception). We rely to the component realization of empty tree.

(We have faced with preformance issue then we have > 1000 nodes in this tree. So many data sends to client)

* Disable node serialization. At now, we don't send serialized node data to the client. Because it decrease performance and have no sense. Previos realization do nothing with this data.
* We send nodeInternalId back from client. So, we can find actual node by this id.
* Pass [] empty array in case there b:tree has no value. (More natural then throwing an exception). We rely to the component realization of empty tree.

(We have faced with preformance issue then we have > 1000 nodes in this tree. So many data sends to client)
@stephanrauh
Copy link
Collaborator

I've stumbled over the same issue an hour ago. Problem is, AJAX breaks without node serialization. Please double-check if AJAX still works with your PR.

@stephanrauh
Copy link
Collaborator

Did you remove these lines deliberately, or is it just because you've forked before I added them?

		Node value = tree.getValue();
		if (null == value) {
			throw new FacesException("Please set the value attribute of b:tree. ClientId of the tree without value: " + clientId);
		}

@PokimonZerg
Copy link
Contributor Author

AJAX still works. Tested on our corporate portal page.

Yes, I have removed this exception directly. Replaced with empty JSON array [].

@stephanrauh stephanrauh merged commit 58a0f85 into TheCoder4eu:master Apr 15, 2017
@stephanrauh
Copy link
Collaborator

Thanks for contributing this PR!

You're lucky: we've just decided to delay the next version of BootsFaces to Monday or to next weekend. So we can merge your last-minute pull request without risk.

@stephanrauh
Copy link
Collaborator

@PokimonZerg May I mention your name in the "Kudos" section of the BootsFaces 1.1.0 release post?

@TheCoder4eu TheCoder4eu mentioned this pull request May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants