Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for DateTimePicker inline disabling; Fixed DateTimePicker defaultDate not working; Fixed inline DateTimePicker not setting value correctly. #508

Merged
merged 4 commits into from
Sep 18, 2016

Conversation

MitchTalmadge
Copy link
Contributor

The first part of the commit adds the functionality explained here: #507 (comment)

The second part fixes the initialDate attribute of DateTimePicker (which equates to defaultDate in javascript) having no effect in the same way that minDate and maxDate did not.

…faultDate (initialDate) having no effect in DateTimePicker.
@MitchTalmadge MitchTalmadge changed the title Add support for DateTimePicker inline disabling; Fixed DateTimePicker defaultDate not working. Added support for DateTimePicker inline disabling; Fixed DateTimePicker defaultDate not working. Sep 17, 2016
@MitchTalmadge
Copy link
Contributor Author

Added another commit to solve the problem as stated here: #482

@MitchTalmadge MitchTalmadge changed the title Added support for DateTimePicker inline disabling; Fixed DateTimePicker defaultDate not working. Added support for DateTimePicker inline disabling; Fixed DateTimePicker defaultDate not working; Fixed inline DateTimePicker not setting value correctly. Sep 18, 2016
@MitchTalmadge
Copy link
Contributor Author

Added another commit because the date attribute of the date time picker library was only being set on inline dateTimePickers. It really should be set on all modes:

image

If this is not set, the date chosen may not match the value passed in, which is completely unexpected. Sometimes it's the minDate, sometimes something else, but it's completely unpredictable -- even when the value is not null.

@MitchTalmadge
Copy link
Contributor Author

MitchTalmadge commented Sep 18, 2016

Actually please hold on merging this for a bit, I need to test it some more.

@MitchTalmadge
Copy link
Contributor Author

MitchTalmadge commented Sep 18, 2016

Ok, all good to merge.

The reason for the downgrade of the javascript file is because the latest version has a bug that causes the selected time to automatically revert back to whatever it was in the beginning when switching days. Not only that, but when using minDate, times would often be disabled for selection even when they were valid, which prevented the user from selecting the desired time.

I will keep watch on the datetimepicker library and update this component with a fixed version as one is released, but for now, the version I have committed works very well.

@asterd asterd merged commit 33f467e into TheCoder4eu:master Sep 18, 2016
@asterd
Copy link
Collaborator

asterd commented Sep 18, 2016

Hi @MitchTalmadge, thank you very much for your contribution: as I've already said, there is a lot of work to do, and sadly the time is ever the same! It would be gracefully to work more time on this project but is not always possible: so, all your contributions are well accepted, and every issue open let us improve our framework! Thank you!

@MitchTalmadge
Copy link
Contributor Author

@asterd No worries, friend! I'm here to help. The framework you guys have created has enabled me to carry out my dreams in less time than I had ever thought possible. This is the least I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants