fixed modal accessibility issue #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed the aria-hidden=true that made the modal invisible for the screen reader. Fix TheCoder4eu#1009
|
That's a surprise! We copied the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed the aria-hidden=true that made the modal invisible for the screen reader.
Fix #1009
I found what was really causing the issue with the screen reader ~:star:
the aria-hidden=true is still there when the modal is open that is why it gets ignored!
The problem is that aria-hidden was introduced in the bootstrap 4 modal but we are using the bootsrap 3 modal.js.
If BF stays with bootsraps 3 we can't use the aria-hiddenfor this component.