Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote command used with onclick event in Firefox #916

Closed
Entrodox opened this issue Feb 20, 2018 · 2 comments
Closed

Remote command used with onclick event in Firefox #916

Entrodox opened this issue Feb 20, 2018 · 2 comments
Assignees
Labels
Milestone

Comments

@Entrodox
Copy link

Hi,

We get an error when using b:remoteCommand with a simple div with onclick event referencing the remoteCommand.

ReferenceError: event is not defined
openChat_0

<script id="ticket_form:j_idt33:0:j_idt39">function openChat_0(){BsF.ajax.callAjax(document.getElementById('ticket_form:j_idt33:0:j_idt39'), event,'ticket_form:chatWindows','ticket_form:j_idt33:0:j_idt39', null, null, null, null);}</script>

The above script generated from our code. I saw a similair issue ( #490 ), could something like that can happen here too?

It works well with the primefaces remoteCommand.

BootsFaces version: 1.2.0
PrimeFaces version: 6.1
Firefox version: 58.0.2 (64-bit)

@stephanrauh
Copy link
Collaborator

Seems like no team member's using Firefox... but you're right, we should support it!

@stephanrauh stephanrauh self-assigned this Feb 20, 2018
stephanrauh added a commit to TheCoder4eu/BootsFacesWeb that referenced this issue Feb 21, 2018
@stephanrauh
Copy link
Collaborator

I've fixed the bug. You can test the bugfix using the developer snapshot BootsFaces-1.2.1-SNAPSHOT. See #369 on how to get it.

BTW, thanks for the good analysis which made finding and repairing the bug a breeze!

@stephanrauh stephanrauh added this to the v1.5.0 milestone Feb 21, 2018
@stephanrauh stephanrauh modified the milestones: v1.5.0, v1.3.0 Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants