Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message.severity is documented, but it hasn't been implemented yet #901

Closed
stephanrauh opened this issue Jan 8, 2018 · 4 comments
Closed

Comments

@stephanrauh
Copy link
Collaborator

At some point in time, we've implemented the attribute Messages#severity to filter which messages are to be displayed. We've documented it both for b:messages and b:message, but it seems we've only implemented it in the plural version.

@jepsar
Copy link
Contributor

jepsar commented Feb 9, 2018

Does it make sense for a single message? I thought it wouldn't and only implemented it on the plural version. Anyhow, I could add it the the singular version as well to keep things consistent.

@stephanrauh
Copy link
Collaborator Author

Ah, that's why it's missing! I think we should keep things consistent - either by removing the attribute from the *jsfdsl (thus removing it from the documentation and from the taglib), or by implementing it.

If you'd like to provide a PR, we'd appreciate this a lot!

@jepsar
Copy link
Contributor

jepsar commented Feb 10, 2018

I just checked, there is no severity attribute for b:message in the jsfdsl file. Maybe the text at https://showcase.bootsfaces.net/forms/messages.jsf#severity could be improved, explicitly stating it only works with b:messages.

stephanrauh added a commit to TheCoder4eu/BootsFacesWeb that referenced this issue Jun 1, 2018
@stephanrauh
Copy link
Collaborator Author

I've updated the documentation.

@stephanrauh stephanrauh self-assigned this Jun 1, 2018
@stephanrauh stephanrauh added this to the v1.5.0 milestone Jun 1, 2018
@stephanrauh stephanrauh modified the milestones: v1.5.0, v1.3.0 Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants