Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more flexible CSS styling options for b:progressbar #850

Closed
stephanrauh opened this issue Aug 26, 2017 · 3 comments
Closed

more flexible CSS styling options for b:progressbar #850

stephanrauh opened this issue Aug 26, 2017 · 3 comments
Assignees
Milestone

Comments

@stephanrauh
Copy link
Collaborator

<b:progressBar> consists of two nested divs. The inner div is can be influenced by setting style and styleClass.

I suggest to apply the styles to the outer div. For the inner div, we could add content-style and content-class.

However, that's a breaking change. Do you think that's a problem? The alternative would be to introduce new attributes name container-style and container-class, which makes the attribute names harder to learn.

stephanrauh added a commit that referenced this issue Aug 26, 2017
@stephanrauh
Copy link
Collaborator Author

I've pushed the change to GitHub so you can test it yourself.

stephanrauh added a commit to TheCoder4eu/BootsFacesWeb that referenced this issue Aug 27, 2017
@stephanrauh
Copy link
Collaborator Author

@asterd @TheCoder4eu @ggam @chongma @zhedar I haven't heard from you, so allow me to "ping" you explicitly. As you can see in the history of the GitHub issue, I've committed a breaking change. I suppose we can get away with it, but I'd like to hear your opinion.

I close the issue nonetheless. We can re-open it at any time :).

@stephanrauh stephanrauh self-assigned this Aug 29, 2017
@stephanrauh stephanrauh added this to the v1.2.0 milestone Aug 29, 2017
@chongma
Copy link
Collaborator

chongma commented Aug 29, 2017

Hi i didn't realise you were the original reporter of this issue or that you were awaiting feedback from me. I haven't used the progress bar component before so I am not familiar with how it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants