Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

b:label puts col-XX both on its div and on its wrapper #741

Closed
ggam opened this issue Apr 28, 2017 · 1 comment
Closed

b:label puts col-XX both on its div and on its wrapper #741

ggam opened this issue Apr 28, 2017 · 1 comment
Assignees
@stephanrauh
Labels
bug confirmed
Milestone
v1.1.0

Comments

@ggam
Copy link
Collaborator

ggam commented Apr 28, 2017

The following html gets rendered when using col-sm-4 on a label:

<div class="col-sm-4" id="j_idt231">
    <span class="label label-danger col-sm-4 ">small-screen='one-third'</span>
</div>

The col-sm-4 class should only be present on the outer div. This does not affect badges.
@stephanrauh stephanrauh self-assigned this Apr 28, 2017
@stephanrauh stephanrauh added this to the v1.1.0 milestone Apr 28, 2017
stephanrauh added a commit that referenced this issue Apr 29, 2017
@stephanrauh
#741 add the responsive style class only once, and add display="block…
4f04304 
…" for labels with responsive style classes
@stephanrauh
Copy link
Collaborator

Fixed. Like requested in #673, I also added display="block". Apparently, that didn't work when I looked at the bug two weeks ago because of the double column definition.

@TheCoder4eu TheCoder4eu mentioned this issue May 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephanrauh stephanrauh

Labels
bug confirmed
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
2 participants
@ggam @stephanrauh