Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code Review] Duplicate method in SelectMultiMenuRenderer #671

Closed
stephanrauh opened this issue Apr 2, 2017 · 1 comment
Closed

[Code Review] Duplicate method in SelectMultiMenuRenderer #671

stephanrauh opened this issue Apr 2, 2017 · 1 comment
Assignees
@stephanrauh
Labels
enhancement
Milestone
v1.1.0

Comments

@stephanrauh
Copy link
Collaborator

The method collectOptions() seems to be a duplicate of SelectItemUtils.collectOptions().
@stephanrauh stephanrauh self-assigned this Apr 2, 2017
stephanrauh added a commit that referenced this issue Apr 2, 2017
@stephanrauh
#671 eliminated the code duplication
aaf9dad
@stephanrauh
Copy link
Collaborator Author

Done.

@stephanrauh stephanrauh added this to the v1.1.0 milestone Apr 2, 2017
@TheCoder4eu TheCoder4eu mentioned this issue Apr 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephanrauh stephanrauh

Labels
enhancement
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
2 participants
@stephanrauh @TheCoder4eu