Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datepicker uses internal Mojarra classes #6

Closed
stephanrauh opened this issue Nov 8, 2014 · 7 comments
Closed

Datepicker uses internal Mojarra classes #6

stephanrauh opened this issue Nov 8, 2014 · 7 comments

Comments

@stephanrauh
Copy link
Collaborator

DatePicker.java line 132: com.sun.faces.util.MessageFactory.getMessage does not belong to the JSF API. This breaks Apache MyFaces compatibility.

@TheCoder4eu
Copy link
Owner

Thanks for pointing this out, although I think most people use Mojarra, we should offer a solution that works on all implementations of JSF.

@TheCoder4eu TheCoder4eu added this to the v0.5.1 milestone Nov 9, 2014
@stephanrauh
Copy link
Collaborator Author

@tandraschko keeps telling me MyFaces is often used, especially by people who care about performance, so we shouldn't ignore this section of the market.

@TheCoder4eu
Copy link
Owner

Yes, that's what I was saying...
I'll look how to solve that ASAP.

On Sun, Nov 9, 2014 at 6:50 PM, Stephan Rauh [email protected]
wrote:

@tandraschko https://github.com/tandraschko keeps telling me MyFaces is
often used, especially by people who care about performance, so we
shouldn't ignore this section of the market.


Reply to this email directly or view it on GitHub
#6 (comment)
.

@stephanrauh
Copy link
Collaborator Author

Now the DatePicker is compatible to MyFaces, too. Before closing the issue I'd like to double-check my changes.

@TheCoder4eu
Copy link
Owner

Great,
what did you use instead of the Mojarra classes?

On Tue, Nov 25, 2014 at 11:53 PM, Stephan Rauh [email protected]
wrote:

Now the DatePicker is compatible to MyFaces, too. Before closing the issue
I'd like to double-check my changes.


Reply to this email directly or view it on GitHub
#6 (comment)
.

@TheCoder4eu
Copy link
Owner

Are the changes ok? If it is so we can change the Milestone to 0.6.0 .

@stephanrauh
Copy link
Collaborator Author

Yes, I think the changes are ok.

@stephanrauh stephanrauh modified the milestones: v0.6.0, v0.6.5 Dec 20, 2014
stephanrauh pushed a commit that referenced this issue Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants