Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bootstrap Slider (b:slider2) Issues #592

Closed
3 tasks done
TheCoder4eu opened this issue Dec 18, 2016 · 6 comments
Closed
3 tasks done

Fix Bootstrap Slider (b:slider2) Issues #592

TheCoder4eu opened this issue Dec 18, 2016 · 6 comments
Assignees
Labels
Milestone

Comments

@TheCoder4eu
Copy link
Owner

TheCoder4eu commented Dec 18, 2016

The new component b:slider2 introduced with v1.0.0 needs some fixes/enhancements before leaving experimental status:

  • 🚫 the value of the input box changes only sliding the slider and not clicking on the slide bar
  • the old Slider had as feature changing size of the sliding handle, we have to adapt CSS for this new component as shown in Example 10 in the documentation here http://seiyria.com/bootstrap-slider/
  • the old Slider didn't allow to move the handle if the slider is disabled or readonly, we have to keep the same behaviour
  • we should fix how input floats are handled now the user cannot type commas in inputs ( JS issue, also rework the page: IMHO all sliders should demo with integers an we should have a specific float demo)
@TheCoder4eu
Copy link
Owner Author

Reverted Slider2 to a Integer Slider.

TheCoder4eu added a commit that referenced this issue Apr 9, 2017
@TheCoder4eu
Copy link
Owner Author

Fix to not allow to move the handle if the slider is disabled.

TheCoder4eu added a commit that referenced this issue Apr 9, 2017
@TheCoder4eu
Copy link
Owner Author

Added support for different size s Handle.
Warning: I had to do a trivial patch to the slider JS to get additional custom classes accepted.
TODO: add info on custom handle in Doc.

@TheCoder4eu
Copy link
Owner Author

TheCoder4eu commented Apr 10, 2017

The value of the input box changes only sliding the slider and not clicking on the slide bar

This happens also in Example 6, I suspect that the click events are not handled.

@TheCoder4eu
Copy link
Owner Author

The click events are intercepted, so I have no way to get the click event.
Surprisingly, the aria attributes on the handle are updated, so it is a "bug" of the library, they missed updating the input value too.
There could be a way detecting aria attribute change but it would be better and cleaner if the library does it.

@TheCoder4eu
Copy link
Owner Author

I close this Issue, I opened Issue #699 for the click problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants