Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appending and prepending facets are rendered incorrectly #511

Closed
stephanrauh opened this issue Sep 25, 2016 · 2 comments
Closed

Appending and prepending facets are rendered incorrectly #511

stephanrauh opened this issue Sep 25, 2016 · 2 comments
Assignees
Milestone

Comments

@stephanrauh
Copy link
Collaborator

stephanrauh commented Sep 25, 2016

Between BootsFaces 0.7 and BootsFaces 0.9.1 we've converted the HTML code to something I considered to be cleaner at the time. Unfortunately, since then browsers ignore the CSS inline style of facet, so we have to revert that.

Example:

JSF code:

<b:inputText value="#{userMgmtBean.company}" style="width: 250px;">
     <f:facet name="prepend">
           <h:outputText  value="Company" style="width: 100px; text-align: left;"/>
     </f:facet>
</b:inputText> 

Broken HTML code:

<div class="input-group">
    <span class="input-group-addon">
        <span class="input-group-addon" style="width: 100px; text-align: left;">Company</span>
    </span>
    <input name="..." type="text" class="form-control bf-no-message has-success" style="width: 250px;">
</div>

Working HTML code:

<div class="input-group">
    <span class="input-group-addon" style="width: 100px; text-align: left;">Company</span>
    <input name="..." type="text" class="form-control bf-no-message has-success" style="width: 250px;">
</div>
@stephanrauh
Copy link
Collaborator Author

stephanrauh commented Nov 10, 2016

Potentially affected components:

  • DatePicker (doesn't support facets yet)
  • DateTimePicker (doesn't support facets yet)
  • SelectBooleanCheckbox (doesn't support facets yet)
  • SelectMultiMenu (doesn't support appending facets)
  • SelectOneMenu
  • ColorPicker
  • InputText
  • InputTextarea

stephanrauh added a commit that referenced this issue Nov 10, 2016
appending and prepending facets were rendered incorrectly
@stephanrauh
Copy link
Collaborator Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant