datepicker / dateTimePicker label missing from taglib

[NicolaIsotta]

The "label" attribute is missing from the taglib for these components, so the IDE complains:

Also, these components does not automatically generate the <label> element before. Is this a wanted behavior?

[stephanrauh]

It's interesting that two components that are so different suffer from the same bug. We've decided to deprecate the b:datePicker in favor of the b:dateTimePicker. The new component is every bit as powerful as the old one, but it doesn't require jQueryUI.

Currently, the label attribute isn't used by the DatePicker. Nor is it used by the DateTimePicker. That's why your IDE is complaining. It's right :).

I've added support for the label to b:dateTimePicker this evening. Along the way, I've noticed that the component should always be embedded by <div class="form-group">. If you prefer inline forms, it should also be embedded in a <div class="form-inline">. You did this in your example manually, but that should be code generated by the component itself. Do you agree?

[NicolaIsotta]

Currently, the label attribute isn't used by the DatePicker. Nor is it used by the DateTimePicker. That's why your IDE is complaining. It's right :).

Actually, it's used by validation messages (that's why I thought it was missing from taglib).

Along the way, I've noticed that the component should always be embedded by <div class="form-group">. If you prefer inline forms, it should also be embedded in a <div class="form-inline">. You did this in your example manually, but that should be code generated by the component itself. Do you agree?

Yep.

Another thing. I've noticed the <input> generated part of the dateTimePicker doesn't allow direct keyboard input because of the z-index. Is this wanted? And is it possible to clear the <input> value?

[stephanrauh]

Keyboard input should be allowed. Let's see what we can do about it.

[NicolaIsotta]

I forgot to add keyboard input doesn't work only if the component is inside a p:dialog. IDK if it works with b:modal because I'm stuck with p:dialog for validation.

[stephanrauh]

I've tried to investigate the z-index. As far as I can see, the z-index of prime:dialog is in the 1002 range. The z-index of the dateTimePicker is set to 2 in the core.css (i.e. a Bootstrap file). I take it raising the z-index to - say- 2000 should do the trick? We did this for b:datePicker (see https://github.com/TheCoder4eu/BootsFaces-OSP/blob/master/gradleResources/staticResources/css/bsf.css, lines 35ff).

[NicolaIsotta]

Setting the z-index to 2000 would cause this:

z-index: inherit !important; seems to work instead.

[NicolaIsotta]

I guess this can be closed @stephanrauh @TheCoder4eu

[stephanrauh]

I think so, too.