Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootswatch (lumen) is shaking since BootsFaces 0.8.6 #412

Closed
mydeadlyvenoms opened this issue Jun 15, 2016 · 9 comments
Closed

Bootswatch (lumen) is shaking since BootsFaces 0.8.6 #412

mydeadlyvenoms opened this issue Jun 15, 2016 · 9 comments
Milestone

Comments

@mydeadlyvenoms
Copy link

After upgrading to BootsFaces 0.8.6 the Bootswatch lumen theme started to shake in vertical direction (on hover). I think this can be a pretty annoying bug especially if one is using buttons within a table.

You may have to switch the theme multiple times since sometime the old css seems to be used.

BootsFaces Example (please make sure you are using the lumen theme)

If you check the original theme, everything seems to be ok:

Bootswatch Example

@zhedar
Copy link
Collaborator

zhedar commented Jun 15, 2016

You are right, it looks like the button should look like it is pressed down and therefore the parent expands to the bottom on mouse hover, making it look shaking.
According to the title, this is a new issue introduced with 0.8.6? Did you see it before as well?

Also our themes in the showcase seem to be broken a bit. For example, if you select readable first, then lumen, the style is a bit... mixed.

@mydeadlyvenoms
Copy link
Author

Yes this appeared after migrating to 0.8.6.
I guess it has to to with the fact, that the look of lumen changed with this release.
Yep I also noticed this behavior.

@zhedar
Copy link
Collaborator

zhedar commented Jun 16, 2016

Yeah probably, also #390 should make this a bit harsh to work around, because you can't really overwrite those css properties yourself, which should be the easiest fix.
What should work, if you really need that right now is to define an inline style which overwrites .btn:hover's margin-top and border-bottom-width attributes and set's them to 0 px each.

Meanwhile I will look into the theming and see if we can overwrite that centrally.

However, this change will remove the button pressing "animation", but who needs that anyway?

@zhedar
Copy link
Collaborator

zhedar commented Jun 16, 2016

Ok, it wasn't exactly 0 pixels, but I got it working by overriding that setting for every theme. Due to http://www3.bootsfaces.net/Showcase/forms/buttons.jsf it seems to work.

@zhedar zhedar closed this as completed Jun 16, 2016
@zhedar zhedar added this to the v0.9.0 milestone Jun 16, 2016
@mydeadlyvenoms
Copy link
Author

@zhedar the "bugfix" is not online or is it?
http://www3.bootsfaces.net/Showcase/forms/buttons.jsf is still shaking when I use the lumen theme.

@zhedar
Copy link
Collaborator

zhedar commented Jun 17, 2016

I guess that's because we still got a bug with the theme switching. But that should be gone after you selected the theme and then refresh the whole site. The theme should be loaded properly then.

@mydeadlyvenoms
Copy link
Author

mydeadlyvenoms commented Jun 17, 2016

Unfortunately this doesn't solve the problem.. The "shaking issue" does not appear when you refresh the page? Maybe I am doing something wrong..

@zhedar
Copy link
Collaborator

zhedar commented Jun 17, 2016

I had to reload the page without submitting the original request though. Entering http://www3.bootsfaces.net/Showcase/forms/buttons.jsf again would do the same.

@mydeadlyvenoms
Copy link
Author

Got it, now it works. 👍 Thanks you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants