Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unnecessary br tag in modal header #379

Closed
lyahim opened this issue May 17, 2016 · 1 comment
Closed

unnecessary br tag in modal header #379

lyahim opened this issue May 17, 2016 · 1 comment
Assignees
@TheCoder4eu
Labels
confirmed enhancement Markup
Milestone
v0.8.6

Comments

@lyahim
Copy link
Contributor

lyahim commented May 17, 2016 •
edited
Loading

Hello All,

In modal header there is a br tag, what I think not needed to there. What do you think?

<div class="modal-header"><button type="button" class="close" data-dismiss="modal">×</button><h4 id="loanForm:loanRepeat:0:loanModal_Label">Accept</h4>**<br>**</div>

Best Regards,
Mihaly
@TheCoder4eu TheCoder4eu added this to the v0.8.6 milestone May 17, 2016
@TheCoder4eu TheCoder4eu self-assigned this May 17, 2016
@TheCoder4eu
Copy link
Owner

Thanks for reporting this I'll have a look to see if it had some reason for being rendered.

TheCoder4eu pushed a commit that referenced this issue May 18, 2016
Fix #379 unnecessary br tag in modal header.
1b6ed98
@TheCoder4eu TheCoder4eu mentioned this issue May 19, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheCoder4eu TheCoder4eu

Labels
confirmed enhancement Markup
Projects
None yet
Milestone
v0.8.6
Development

No branches or pull requests
2 participants
@lyahim @TheCoder4eu