Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p:calendar doesn't show button with BootsFaces 0.8.0 and PrimeFaces 5.3 #324

Closed
nokiajavi opened this issue Mar 11, 2016 · 15 comments
Closed

Comments

@nokiajavi
Copy link

When I use BootsFaces 0.8.0 and PrimeFaces 5.3 the component p:calendar does not show the button with option showOn button.

Example:

<p:calendar value=#{listForm.date}" mode="popup" size="8" showOn="button" />

With BootsFaces 0.7.0 it works correctly. Higher versions fails.

@nokiajavi nokiajavi changed the title p:calendar not show botton with bootfaces 0.8.0 and Priemfaces 5.3, Don't Work p:calendar not show button with bootfaces 0.8.0 and Priemfaces 5.3, Don't Work Mar 11, 2016
@stephanrauh
Copy link
Collaborator

I didn't manage to reproduce your error. What precisely does not work? I've tried both BootsFaces 0.8.0 and 0.8.2-SNAPSHOT. When I click on the icon, the calendar shows as expected.

<p:outputLabel for="issue327" value="Issue 327" />
<p:calendar value="#{calendarView.date3}" mode="popup" size="8" showOn="button" id="issue327"/

image

@stephanrauh stephanrauh changed the title p:calendar not show button with bootfaces 0.8.0 and Priemfaces 5.3, Don't Work p:calendar doesn't show button with BootsFaces 0.8.0 and PrimeFaces 5.3 Mar 13, 2016
@nokiajavi
Copy link
Author

When I start the app , I get this warning
WARNING: JSF1064: Unable to find or serve resource, css/default/icons.css, from library, bsf.

perhaps it may be a conflict with libraries , I use the library in pom.xml Bootstrap 3.0.2 , plus bootstraps of PrimeFaces and bootfaces . Total 3 libraries bootstraps

I'll fix itentar surely be my problem , thank you, and if I mention I was solved.

EDIT: I found the .CSS that hide button:
.ui-datepicker-trigger {
display: none;
}
if I delete that style , shown button and calendaar works perfectly .
From: http://localhost:8080/Example/javax.faces.resource/css/default/bsf.css.xhtml?ln=bsf

@zhedar
Copy link
Collaborator

zhedar commented Apr 25, 2016

While exploring the PrimeFaces 6.0 issues I just found primefaces/primefaces#1256. Maybe that's the one solving your problem. 6.0RC1 is now available.
@nokiajavi Maybe you can check that out and we can close this issue?

@nokiajavi
Copy link
Author

Hi!

I have included the new version of PrimeFaces , there is a problem and I do not load the file primefaces.css . Surely I have a problem with any filter settings .
If it is of interest , I have created the project with AppFuse
Greetings and thanks

@zhedar
Copy link
Collaborator

zhedar commented Apr 27, 2016

Could you mention, which problem actually? This may be a PrimeFaces issue then.

@nokiajavi
Copy link
Author

nokiajavi commented Apr 28, 2016

I created the project with AppFuse , including JSF and Primefaces , Bootfaces , Omnifaces , Spring and multiples filters (prettyFilter, rewriteFilter, securityFilter, wroFilter )...
Currently I have PrimeFaces bootfaces 5.3 and 0.0.7 and I have no problems.
By including a version higher than 0.0.7 bootfaces errors are generated across the web . The most common is that you can not load the css PrimeFaces .

I tried to solve errors in the footsteps of its web , with resourcehandler of omnifaces , but still does not load the .css

As I start the app , indicating RESNOTFOUND.xhtml navigation fails , the inability to load some .css etc ..

@zhedar
Copy link
Collaborator

zhedar commented May 1, 2016

With the current information it's quite hard to near impossible to diagnose the problem.
Therefore I have some additional questions:

  • Did you test the current 0.8.2-SNAPSHOT, as Stephan suggested? (Most of those problems should be fixed there.)
  • Which CSS files exactly couldn't be loaded?
  • Which error messages are displayed?
  • Could you try to provide a minimal example which allows us to reproduce these problems?

@nokiajavi
Copy link
Author

nokiajavi commented May 3, 2016

Hello, I tested with version 0.8.2 - snapshop , this version does not generate any error loading .CSS or anything. But still does not show the calendar button.

This is the code that makes the button is not shown:
.ui- datepicker -trigger {
display: none;
}

It is the file that hides the button, is bootfaces css : http://localhost:8080/JSF/javax.faces.resource/css/default/bsf.css.xhtml?ln=bsf

It seems that overrides the CSS of PrimeFaces class .ui -button:
.ui- button {
display : inline - block;
position: relative ;
padding: 0;
margin-right : .1em ;
text- decoration: none ! important;
cursor : pointer;
text-align : center;
zoom: 1;
overflow: visible ;

Example Code:

<ui:define name="body">
<h:form id="personaForm" prependId="false">
  <p:growl id="messages" showDetail="true" />
<h:panelGroup id="panelDetallePersona" layout="block" class="well">
<p:tabView id="tab" effect="fade" effectDuration="fast"  prependId="false" dynamic="true">
  <p:tab id="tabInfo" title="#{text['personaForm.tabInfo']}">
    <b:panelGrid colSpans="2,4,2,4" >
     <h:outputLabel value="#{text['personaForm.inicioPrestacion']}:"/>
     <h:panelGroup> 
      <p:calendar id="inicioPrestacion" value="#{personaForm.fhinipre}"  
         showButtonPanel="true" size="10" showOn="button" navigator="true" 
        locale="# {text['calendar.language']}" 
        mindate="#{personaForm.minDateInicioPrestacion}" 
        maxdate="#{personaForm.maxDateIniPres}" 
        selectOtherMonths="true" pattern="dd/MM/yyyy" readonlyInput="true" 
        label="#{text['personaForm.inicioPrestacion']}" 
        disabled="#{empty personaForm.domicilios or personaForm.puedeCambiarFechaInicio() eq false}">
         <p:ajax event="dateSelect"  update="finPrestacion borrarFechaIni borrarFechaFin" />
       </p:calendar>
       <p:commandButton id="deleteDate"  icon="ui-icon ui-icon-close" title="#{text['button.title.BorrarFechaIniPres']}" action="#{personaForm.borrarFechaIniPres}"
 update="@this inicioPrestacion " 
disabled="#{personaForm.puedeBorrarFechaInicio() eq false}" />
        </h:panelGroup>
..... .....
</b:panelGrid>
</p:tab>
</p:tabView>
</h:panelGroup>
</h:form>
</ui:define>

@zhedar
Copy link
Collaborator

zhedar commented May 3, 2016

Did you try PrimeFaces 6.0.RC2 as well? As for as I know, bsf.css should be rendered before primefaces.css, therefore primefaces should override some of its settings.
Thanks for the example code, may try to reproduce that if I get to it.

@nokiajavi
Copy link
Author

With de Primefaces 6.0.RC2 and Bootfaces 0.8.2-SNAPSHOP Show the following error:
Unable to find resource primefaces, primefaces.css

@zhedar
Copy link
Collaborator

zhedar commented May 3, 2016

I had this error as well, turned out, that I included primefaces.css in one of my h:outputStylesheets. The migration guide says that it was replaced by core.css and components.css, so you have to to that as well, if you need it explicitly.

Edit: Although I'm not sure about this anymore, because the guide only mentions *.js files. Maybe all I did was removing the manual including of primefaces.css.
Do you have PimeFaces Extensions included as well? Because that isn't compatible with PF6 yet.

@nokiajavi
Copy link
Author

Yes, I have PFE 4.0.0 included

@nokiajavi
Copy link
Author

hello looking at the web boortfaces , I have seen the failure calendar button not shown .
You can check it by going to showcase yourself the page bootsfaces:

http://showcase.bootsfaces.net/integration/PrimeFaces.jsf

I enclose a screenshot so you see today what is happening .
sin titulo

regards

@stephanrauh
Copy link
Collaborator

stephanrauh commented Jun 14, 2016

Oops, you are right. Thanks for pointing this out! As a fast workaround, you can add this css style:

<style>
.ui-calendar > .ui-datepicker-trigger {
  display:inline;
}
</style>

@stephanrauh
Copy link
Collaborator

I've fixed this bug in BootsFaces 0.9.0. This version is due very soon - either this weekend or the next weekend.
You can review the bugfix at our development showcase: http://www3.bootsfaces.net/Showcase/integration/PrimeFaces.jsf.

@stephanrauh stephanrauh added this to the v0.9.0 milestone Jun 14, 2016
@stephanrauh stephanrauh self-assigned this Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants