Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTableRenderer:encodeEnd wrong logic #1101

Closed
TheOneSV opened this issue Nov 5, 2019 · 2 comments · Fixed by #1124
Closed

DataTableRenderer:encodeEnd wrong logic #1101

TheOneSV opened this issue Nov 5, 2019 · 2 comments · Fixed by #1124
Assignees
@geopossachs
Labels
bug dataTable Issues with the main Topic dataTable Solved This ticket has been solved. If it's still open, we're waiting for the user's confirmation.
Milestone
v1.5.0

Comments

@TheOneSV
Copy link

TheOneSV commented Nov 5, 2019

There is a problem in the DataTableRenderer::encodeEnd function

int start = customOptions.indexOf("language" + "language".length());

Should be

int start = customOptions.indexOf("language") + "language".length();
@TheOneSV TheOneSV changed the title DataTableRendered:encodeEnd wrong logic DataTableRenderer:encodeEnd wrong logic Nov 5, 2019
@vsvetoslavov
Copy link
Contributor

To clarify a bit - this causes the language url to be injected after the first { occurrence. This breaks custom options quite aggressively.

@geopossachs geopossachs added the dataTable Issues with the main Topic dataTable label Nov 24, 2019
@geopossachs geopossachs modified the milestone: v1.5.0 Nov 24, 2019
@geopossachs geopossachs added this to the v1.5.0 milestone Nov 24, 2019
@geopossachs geopossachs self-assigned this Nov 24, 2019
geopossachs added a commit to geopossachs/BootsFaces-OSP that referenced this issue Feb 8, 2020
@geopossachs
TheCoder4eu#1101 fix an error in line 612 to get start index
061dc0f
@geopossachs geopossachs mentioned this issue Feb 8, 2020
Merged
stephanrauh pushed a commit that referenced this issue Apr 27, 2020
@geopossachs @stephanrauh
#1101 fix an error in line 612 to get start index
765509c
@stephanrauh stephanrauh added bug Solved This ticket has been solved. If it's still open, we're waiting for the user's confirmation. labels Apr 27, 2020
@stephanrauh
Copy link
Collaborator

Thanks for pointing this out and for providing a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geopossachs geopossachs

Labels
bug dataTable Issues with the main Topic dataTable Solved This ticket has been solved. If it's still open, we're waiting for the user's confirmation.
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging a pull request may close this issue.

#1101 fix an error in line 612 to get start index geopossachs/BootsFaces-OSP
4 participants
@vsvetoslavov @stephanrauh @geopossachs @TheOneSV