Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datepicker does not have space after css class name 'form-group' #1008

Closed
jkbhu85 opened this issue Sep 11, 2018 · 3 comments
Closed

datepicker does not have space after css class name 'form-group' #1008

jkbhu85 opened this issue Sep 11, 2018 · 3 comments
Labels
bug Solved This ticket has been solved. If it's still open, we're waiting for the user's confirmation.
Milestone

Comments

@jkbhu85
Copy link

jkbhu85 commented Sep 11, 2018

datepicker does not have space after css class name 'form-group' which causes appearance problem when the validation fails and new css classes are added to datepicker.

@Lb-lea
Copy link

Lb-lea commented Sep 13, 2018

I looked up datePicker on 1.3.0 version
DatePicker doesn't seem to have any element of class 'form-group'....Did you mean input-group or input-group-addon..
Do you remember on which html element was the problematic class tag?

@jkbhu85
Copy link
Author

jkbhu85 commented Sep 14, 2018

<b:form id="register">
  <b:datepicker required="true" value="#{register.dateOfBirth}" id="dateOfBirth" label="Date of birth" />
  
  <b:formGroup>
    <b:commandButton value="Submit"/>
  </b:formGroup>
</b:form>

This will generate the html something like following:

<div class="form-group" id="register:dateOfBirth">
  <label for="register:dateOfBirth_input" class=" bf-required null control-label">Date of birth</label>
  <div class="input-group ">
    <input id="register:dateOfBirth_input" name="register:dateOfBirth" class="form-control bf-required hasDatepicker" data-dpisvisible="false" type="text">
    <button type="button" class="ui-datepicker-trigger">...</button>
    <span id="register:dateOfBirth_input-group-addon" class="input-group-addon">
      <span><i id="register:dateOfBirth_icon" class="glyphicon glyphicon-calendar"></i></span>
    </span>
  </div>
</div>

The outer most div was supposed to have a space after the class name form-group.
I am using bootsfaces version 1.3.0.

geopossachs pushed a commit to geopossachs/BootsFaces-OSP that referenced this issue May 1, 2019
geopossachs added a commit to geopossachs/BootsFaces-OSP that referenced this issue May 1, 2019
@stephanrauh
Copy link
Collaborator

Solved by merging #1008.

@stephanrauh stephanrauh added the bug label Aug 3, 2019
@stephanrauh stephanrauh added this to the v1.5.0 milestone Aug 3, 2019
@TheCoder4eu TheCoder4eu modified the milestones: v1.5.0, v1.4.2 Aug 28, 2019
@TheCoder4eu TheCoder4eu added the Solved This ticket has been solved. If it's still open, we're waiting for the user's confirmation. label Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Solved This ticket has been solved. If it's still open, we're waiting for the user's confirmation.
Projects
None yet
Development

No branches or pull requests

4 participants