Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made lucky blocks not only spawn on water #51

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Made lucky blocks not only spawn on water #51

wants to merge 3 commits into from

Conversation

Silent-Program
Copy link

Idk, I'm new to GitHub PR's but I fixed the issue where lucky blocks only spawn in water.

@Silent-Program
Copy link
Author

I tested it and everything. It is working, no console errors. I added like 3 lines.

@Silent-Program
Copy link
Author

The build appears to have failed because of an import for material not being present. However, I did import it. I don't know if i did something wrong and its not showing up on the PR
image

@TheBusyBiscuit
Copy link
Owner

You probably forgot to commit and/or push the change

@Silent-Program
Copy link
Author

I just realized that, and pushed it right now

@Silent-Program
Copy link
Author

You probably forgot to commit and/or push the change

The changes have been made and it works properly now.

@Silent-Program
Copy link
Author

Been a while.. I fixed all the issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J3fftw1 J3fftw1 J3fftw1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Silent-Program @TheBusyBiscuit @J3fftw1