Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support import in config #143

Merged
merged 5 commits into from
Jun 11, 2019

Conversation

alanning
Copy link
Contributor

Uses @babel/register to fix Issue #142

@lgandecki
Copy link
Member

Thanks @alanning ! Hmm... I think this will cause the sources not to build before publishing to npm. What was the reasoning behind changing the name prepublish into prepare?

@alanning
Copy link
Contributor Author

Hi @lgandecki, pls see the deprecation notice in npm help scripts for detailed explanation. The specific use for me was to allow me to directly point to the git repo. Since this package needs the compilation step to run before use, it was failing since prepublish didn't trigger it (understandable since we weren't publishing, but still not very helpful).

@lgandecki
Copy link
Member

Cool! Thanks for the clarification. I will play around with it and if all looks good will publish.

@lgandecki lgandecki merged commit aa732e0 into TheBrainFamily:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants