fix: do not terminate random sessions #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the seemingly random `[chimp][hooks] Error: The test with session id XXX has already finished, and can't receive further commands` that happen when using chimp & saucelabs with a high concurrency. The current implementation of the saucelabs-manager retrieves 10 sessions of the current user and kills the first one that has been received, independent of whether that job is managed by the current build or not, which leads to job terminations on concurrently running tests in CI by the same user.
|
I don't really have a way to verify this, as we don't use the saucelabs integration.. but since you are using it in a fork I will merge it in and release as is, if it brakes for someone else, I hope they will open a separate issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the seemingly random
[chimp][hooks] Error: The test with session id XXX has already finished, and can't receive further commandsthat happen when using chimp & saucelabs with a high concurrency.The current implementation of the saucelabs-manager retrieves 10 sessions of the current user and kills the first one that has been received, independent of whether that job is managed by the current build or not, which leads to job terminations on concurrently running tests in CI by the same user.