Implement V2 #165
Draft
Implement V2 #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shopify has settled on a convention of using `pull` for commands that get data from their servers. We see this with the new `theme metafields pull` command. I think we should be consist. Therefore, we're changing the comand name.
We're removing the theme settings download command, but rather than break people's setups, we will provide an alias and alert them that they should change their tooling.
This command is not needed any more. You can achieve a similar result by parsing the result of the theme list --json command.
jeffreyguenther
force-pushed
the
v2-wip
branch
from
e70ee1d to
946b524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I make the improvements that will ship in V2. This will be the working feature branch. Features will be implement in their own branches and PRs and merged here for a final review.