Endian fixes for the Red Alert lobby networking code. #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmniBlade
requested changes
Mar 6, 2023
common/connect.h
Outdated
| @@ -122,6 +123,12 @@ typedef struct | |||
| unsigned int PacketID; | |||
| } CommHeaderType; | |||
|
|
|||
| static inline void SwapCommHeaderType(CommHeaderType* cht) | |||
There was a problem hiding this comment.
inline functions don't need to be marked as static to avoid the one definition rule when defined in headers.
There was a problem hiding this comment.
Changed the static inline functions to just inline.
isojalka
force-pushed
the
ra_net_lobby_endian
branch
from
142b331 to
4c519b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note that this is purely for the lobby. The actual game networking needs its own set of endian fixes.