Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions for templates #146

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

rojepp
Copy link
Contributor

@rojepp rojepp commented Sep 19, 2019

Proposed Changes

Supply GitHub Actions workflows for generated projects.
Fixes #143.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

@TheAngryByrd
Copy link
Owner

So now the question is, should be have different sets of CI available for people to choose from?

I do think eventually going with Github actions as the default when it comes out beta makes sense but probably want to leave the default as AppVeyor/Travis

This involves:

  • Creating a new parameter for which type of CI to use, AppVeyor&Travis / Github Actions / Circle CI (future)/ Gitlab CI (future).
  • Putting the correct files based on that choice
  • Augmenting the README to have the badges based on that choice (does github actions even have badges?)

@rojepp
Copy link
Contributor Author

rojepp commented Sep 19, 2019

There is some badge support, but I haven't tried it.
As for options, I don't know, I find them hard to discover and use in dotnet tools.
The admittedly few times I've used MiniScaffold I just generate and go in and delete stuff I don't want (a lot of it! 😂). I'd rather delete this one file than read up on some option.

I'm not against creating one, I just don't think anyone would care. In the same vein, there are no options for all the stuff I delete - PR/Issue templates, code coverage, generateAssemblyInfo, badges etc.

@TheAngryByrd TheAngryByrd merged commit e7ea4f6 into TheAngryByrd:master Sep 19, 2019
TheAngryByrd pushed a commit that referenced this pull request Sep 20, 2019
* FEATURE: Github Actions (#145) (#146)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding CI through GitHub Actions
2 participants