Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI dotnet versions and targetframeworks #119

Merged
merged 6 commits into from
Feb 16, 2019
Merged

Update CI dotnet versions and targetframeworks #119

merged 6 commits into from
Feb 16, 2019

Conversation

TheAngryByrd
Copy link
Owner

Proposed Changes

This updates the TravisCI dotnet/mono version. This also removes netcoreapp2.0 and include netcoreapp2.2 as targetframeworks.

Types of changes

What types of changes does your code introduce to MiniScaffold?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Jimmy Byrd added 2 commits February 10, 2019 10:52
netcoreapp2.0 has been unsupported since Oct 2018
@baronfel baronfel merged commit 0d13a4d into master Feb 16, 2019
@baronfel baronfel deleted the update-ci branch February 16, 2019 20:05
TheAngryByrd pushed a commit that referenced this pull request Feb 18, 2019
* MINOR: Use Directory.build.props for nuget metadata (#118)
* FEATURE: Update CI dotnet versions and TargetFrameworks to latest (#119)
TheAngryByrd pushed a commit that referenced this pull request Feb 19, 2019
* MINOR: Use Directory.build.props for nuget metadata (#118)
* FEATURE: Update CI dotnet versions and TargetFrameworks to latest (#119)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants