IAsyncEnumerable support #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can't cover inline code which this library is all inline code
TheAngryByrd
force-pushed
the
iasyncenumerable
branch
from
c46c76d to
5e8984a
Compare
TheAngryByrd
force-pushed
the
iasyncenumerable
branch
from
5e8984a to
34362d2
Compare
TheAngryByrd
added a commit
that referenced
this pull request
Nov 22, 2023
## [0.10.0] - 2023-11-21 ### Added - [IAsyncEnumerable support](#37) Credits @TheAngryByrd.
|
Hey @TheAngryByrd I missed this. Do you still need me looking into this? |
|
PS: |
|
Nothing for you to look at. this was more just to make you aware of how I implemented it so you could add it to taskseq for task ce overloads if needed. |
|
Yes, I actually have |
|
We did but it was kind of janky and didn’t have a dynamic implementation |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adds support
forIAsyncEnumerable. Testing against TaskSeqTypes of changes
What types of changes does your code introduce to IcedTasks?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...