Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This fixes an edge case where it's possible for
writeMessage
to try to send a string toString.Format
that looks like it still has format specifiers in it when there are none.I haven't yet been able reproduce this with a toplevel test without reproducing the app I'm working ons environment, but here's a stack trace:
The fix itself also might be done in a better way than two string replacements :/
Types of changes
What types of changes does your code introduce to FsLibLog?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Tested via fsi calling
String.Format
on values as they appeared at runtime when I was seeing the error.