implement simple propertyname logging for the console logger #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Implement mapped contexts for the Console provider. This is needed to use the console provider when you've already implemented named properties in your code and you want to use console logging during a test.
Types of changes
What types of changes does your code introduce to FsLibLog?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
I implemented the propertymap as a stack so we could pop off the elements as scopes are exited.
To do the name replacement we iterate in reverse so that more recent definitions of a message variable are used before older ones.
Name replacement has to happen before positional parameters otherwise String.Format complains.