Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement simple propertyname logging for the console logger #8

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

baronfel
Copy link
Collaborator

Proposed Changes

Implement mapped contexts for the Console provider. This is needed to use the console provider when you've already implemented named properties in your code and you want to use console logging during a test.

Types of changes

What types of changes does your code introduce to FsLibLog?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

I implemented the propertymap as a stack so we could pop off the elements as scopes are exited.
To do the name replacement we iterate in reverse so that more recent definitions of a message variable are used before older ones.

Name replacement has to happen before positional parameters otherwise String.Format complains.

@TheAngryByrd TheAngryByrd merged commit 0dc37e8 into TheAngryByrd:master Oct 31, 2019
TheAngryByrd pushed a commit that referenced this pull request Oct 31, 2019
* FEATURE: Implement simple propertyname logging for the console logger #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants