Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log operators #19

Merged
merged 3 commits into from
Sep 8, 2021
Merged

Conversation

PaigeM89
Copy link
Collaborator

@PaigeM89 PaigeM89 commented Sep 8, 2021

Proposed Changes

Adds some operators to help create & add to logs in a condensed manner.

Types of changes

What types of changes does your code introduce to FsLibLog?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

The operators are based on our discussions & usage. As it would be a pain to change them later, it might be worthwhile to bikeshed them now.

I am not sure how much description to add to the comments on the operators themselves. Ideally we would mirror the functions they're wrapping, but I worry the comments would be out-of-sync at some point.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@TheAngryByrd
Copy link
Owner

Thanks!

@TheAngryByrd TheAngryByrd merged commit 43f0434 into TheAngryByrd:master Sep 8, 2021
TheAngryByrd added a commit that referenced this pull request Sep 17, 2021
* FEATURE: [Adds Logging operators](#19)
* FEATURE: [Adds interpolated strings](#23)
* INFRASTRUCTURE : [Moved to GitHub Workflows](#20)
* INFRASTRUCTURE: [Adds basic tests using a TestProvider](#22)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants