Fix search hanging and servers page #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, this took a bit actually. Since the redis database is created with non-expiring keys, the cache should be intact, without the need for the methods uploadBots, etc. Once I realized that wasn't the problem, I tested manually adding the page=# to the query on the production site- this resulted in pages of results, that didn't seem to be shown. That was a different issue, that is also resolved in this PR. The random bottleneck/hanging on queries such as "anime" or "furry" occurred when I had created empty/fake datasets to have to search through. This makes sense, since some queries work fine, some not. The issue with some terms is the size of the results. It seems that the bottleneck was coming from .map, and expressjs trying to render everything, all results across every page, synchronously. it seems simply changing the inner function of the map where ejs is called to be asynchronous does the trick?