Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing docs and upgrade dependencies #66

Merged
merged 5 commits into from
Oct 12, 2021

Conversation

sentenza
Copy link
Contributor

Close #2

Close #9

Close #41

Tasks

  • Update .gitignore
  • Add Scalafmt
  • Update travis conf
  • Add CONTRIBUTING
  • Update DIRECTORY listing all the missing algorithms taken from Java project Add more algorithms #2
  • Fix README Change readme.md #9
  • Updgrade sbt to v1.5.5 (latest)
  • Upgrade scala to v2.13.6
  • Fix several compiling error (after adding Xlint via tpolect plugin)

@sentenza
Copy link
Contributor Author

sentenza commented Oct 10, 2021

@cclauss There's a wrong pipeline configured for LGTM analysis: JavaScript . We should get rid of it!

@sentenza
Copy link
Contributor Author

@Panquesito7 follow up of our discussion on #9

@cclauss
Copy link
Member

cclauss commented Oct 10, 2021

Also #59

Scala is not supported by LGTM https://lgtm.com/help/lgtm/about-lgtm#languages

@sentenza
Copy link
Contributor Author

sentenza commented Oct 10, 2021

Also #59

Scala is not supported by LGTM https://lgtm.com/help/lgtm/about-lgtm#languages

@cclauss So we should remove LGTM from this project, shouldn't we?

@sentenza
Copy link
Contributor Author

@Panquesito7 This GH workflow should be changed to be compatible with the new Directory scheme used by both Python and Java projects.

.scalafmt.conf Outdated Show resolved Hide resolved
@Panquesito7
Copy link
Member

@Panquesito7 This GH workflow should be changed to be compatible with the new Directory scheme used by both Python and Java projects.

Feel free to make a PR for that, and we'll review it. 🙂

Co-authored-by: David Leal <[email protected]>
@sentenza
Copy link
Contributor Author

@Panquesito7 This GH workflow should be changed to be compatible with the new Directory scheme used by both Python and Java projects.

Feel free to make a PR for that, and we'll review it. 🙂

No idea how to fix that to be honest. I've never seen/used that plugin before. I don't even know where the configuration has been applied to enable it.

@Panquesito7 I applied your suggested change. ;)

@sentenza
Copy link
Contributor Author

@Panquesito7 Could you please add the hacktoberfest tag to this PR?

@Panquesito7 Panquesito7 added enhancement hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 10, 2021
@Panquesito7 Panquesito7 requested a review from a team October 10, 2021 20:02
Copy link
Contributor

@counter2015 counter2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about add scalafmtOnCompile := true in build.sbt ?

@sentenza
Copy link
Contributor Author

How about add scalafmtOnCompile := true in build.sbt ?

@counter2015 I think it would make sense adding a new GitHub workflow for scalafmt on top of that. I'm going to add your suggested change. 👌

build.sbt Show resolved Hide resolved
@cclauss
Copy link
Member

cclauss commented Oct 11, 2021

@Panquesito7 @poyea Do you have access rights to do this?
https://lgtm.com/help/lgtm/managing-automated-code-review#disabling-pr-integration

@sentenza
Copy link
Contributor Author

I guess that all the review comments were addressed and this PR could be merged in.

The LGTM thingy is not related to this PR.

@cclauss @Panquesito7 @counter2015 WDYT? 👂

@poyea
Copy link
Member

poyea commented Oct 11, 2021

@Panquesito7
Copy link
Member

I've disabled the automated code review for now. Let's wait until Anup removes the LGTM integration from this repository. 🙂

@counter2015
Copy link
Contributor

counter2015 commented Oct 12, 2021

I guess that all the review comments were addressed and this PR could be merged in.

The LGTM thingy is not related to this PR.

@cclauss @Panquesito7 @counter2015 WDYT? 👂

LGTM, thanks for your work!

@sentenza
Copy link
Contributor Author

@cclauss @Panquesito7 @counter2015 Can we merge this PR in? I would really love to keep working on other algorithms on top of the changes introduced here. I think that everyone here approved it already.

@cclauss
Copy link
Member

cclauss commented Oct 12, 2021

I am not a Scala person and am not a maintainer of this repo.

@counter2015 counter2015 merged commit 9d93e98 into TheAlgorithms:master Oct 12, 2021
@counter2015
Copy link
Contributor

merged

@sentenza sentenza mentioned this pull request Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A series of compilation/test errors in the math algorithms Change readme.md Add more algorithms
5 participants