-
-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing docs and upgrade dependencies #66
Add missing docs and upgrade dependencies #66
Conversation
@cclauss There's a wrong pipeline configured for |
@Panquesito7 follow up of our discussion on #9 |
Also #59 Scala is not supported by LGTM https://lgtm.com/help/lgtm/about-lgtm#languages |
@cclauss So we should remove LGTM from this project, shouldn't we? |
@Panquesito7 This GH workflow should be changed to be compatible with the new Directory scheme used by both Python and Java projects. |
Feel free to make a PR for that, and we'll review it. 🙂 |
Co-authored-by: David Leal <[email protected]>
No idea how to fix that to be honest. I've never seen/used that plugin before. I don't even know where the configuration has been applied to enable it. @Panquesito7 I applied your suggested change. ;) |
@Panquesito7 Could you please add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about add scalafmtOnCompile := true
in build.sbt
?
@counter2015 I think it would make sense adding a new GitHub workflow for scalafmt on top of that. I'm going to add your suggested change. 👌 |
@Panquesito7 @poyea Do you have access rights to do this? |
I guess that all the review comments were addressed and this PR could be merged in. The LGTM thingy is not related to this PR. @cclauss @Panquesito7 @counter2015 WDYT? 👂 |
No. cc. @AnupKumarPanwar |
I've disabled the automated code review for now. Let's wait until Anup removes the LGTM integration from this repository. 🙂 |
LGTM, thanks for your work! |
@cclauss @Panquesito7 @counter2015 Can we merge this PR in? I would really love to keep working on other algorithms on top of the changes introduced here. I think that everyone here approved it already. |
I am not a Scala person and am not a maintainer of this repo. |
merged |
Close #2
Close #9
Close #41
Tasks