Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to flake8 v6 #8007

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Upgrade to flake8 v6 #8007

merged 2 commits into from
Nov 29, 2022

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Nov 29, 2022 •
edited
Loading

Describe your change:

The new version of flake8 complains about misplaced comments in .flake8

flake8-broken-line is not compatible with flake8 v6 -- wemake-services/flake8-broken-line#280

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Nov 29, 2022
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Nov 29, 2022
@cclauss cclauss merged commit 08c2245 into TheAlgorithms:master Nov 29, 2022
@cclauss cclauss deleted the fix-flake8-comments branch November 29, 2022 15:56
Cjkjvfnby pushed a commit to Cjkjvfnby/Python that referenced this pull request Mar 13, 2023
@cclauss @Cjkjvfnby
Upgrade to flake8 v6 (TheAlgorithms#8007)
4322e21 
* Upgrade to flake8 v6

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

@AnshulMalik AnshulMalik Awaiting requested review from AnshulMalik

@AnupKumarPanwar AnupKumarPanwar Awaiting requested review from AnupKumarPanwar

@poyea poyea Awaiting requested review from poyea

@l3str4nge l3str4nge Awaiting requested review from l3str4nge

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @dhruvmanila