Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isort --profile black . #2181

Merged
merged 7 commits into from
Jul 6, 2020
Merged

isort --profile black . #2181

merged 7 commits into from
Jul 6, 2020

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Jul 6, 2020

Describe your change:

Run isort --profile black . on the entire repo and add that command to our Autoblack GitHub Action.

--recursive was removed from isort in v5.0 https://timothycrosley.github.io/isort/CHANGELOG

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss cclauss force-pushed the isort--profile-black--recursive branch from fbb2495 to d5734e4 Compare July 6, 2020 06:54
@cclauss cclauss requested a review from poyea July 6, 2020 07:00
poyea
poyea approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@cclauss cclauss merged commit 5f4da5d into TheAlgorithms:master Jul 6, 2020
@cclauss cclauss deleted the isort--profile-black--recursive branch July 6, 2020 07:44
@Isabellarossi
Copy link

Describe your change:

Run isort --profile black . on the entire repo and add that command to our Autoblack GitHub Action.

--recursive was removed from isort in v5.0 https://timothycrosley.github.io/isort/CHANGELOG

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@cclauss @stokhos
isort --profile black . (TheAlgorithms#2181)
ea520e3 
* updating DIRECTORY.md

* isort --profile black .

* Black after

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

@l3str4nge l3str4nge Awaiting requested review from l3str4nge

@mrvnmchm mrvnmchm Awaiting requested review from mrvnmchm

@itsvinayak itsvinayak Awaiting requested review from itsvinayak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cclauss @Isabellarossi @poyea