Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Time Conversion Function #10749

Merged
merged 8 commits into from
Oct 22, 2023
Merged

Add: Time Conversion Function #10749

merged 8 commits into from
Oct 22, 2023

Conversation

JeelGajera
Copy link
Contributor

Describe your change:

This PR add the Time unit conversion function.
conversion_chart
chart source

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 21, 2023
@JeelGajera
Copy link
Contributor Author

@cclauss please review this PR.

cclauss
cclauss requested changes Oct 22, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slick!! A few more changes...

conversions/time_conversions.py Outdated Show resolved Hide resolved
conversions/time_conversions.py Outdated Show resolved Hide resolved
conversions/time_conversions.py Show resolved Hide resolved
conversions/time_conversions.py Show resolved Hide resolved
conversions/time_conversions.py Outdated Show resolved Hide resolved
@algorithms-keeper algorithms-keeper bot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Oct 22, 2023
@cclauss cclauss self-assigned this Oct 22, 2023
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Oct 22, 2023
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 22, 2023
JeelGajera
JeelGajera commented Oct 22, 2023
View reviewed changes
Copy link
Contributor Author

@JeelGajera JeelGajera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve the required changes

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 22, 2023
@JeelGajera JeelGajera requested a review from cclauss October 22, 2023 08:43
cclauss
cclauss approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great way to pass the time!

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 22, 2023
@cclauss cclauss merged commit 6c8743f into TheAlgorithms:master Oct 22, 2023
@JeelGajera
Copy link
Contributor Author

Please add hacktoberfest-accepted label so that it can be accepted in hacktoberfest.

@cclauss cclauss added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 22, 2023
@tianyizheng02
Copy link
Contributor

@JeelGajera This repo has the hacktoberfest label, so there is no need to label individual PRs. Your PR will be accepted for Hacktoberfest even without the hacktoberfest-accepted label.

@tianyizheng02 tianyizheng02 mentioned this pull request Oct 22, 2023
Closed
11 tasks
This was referenced Oct 22, 2023
Closed
Closed
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@JeelGajera @pre-commit-ci
@cclauss @sedatguzelsemme
Add: Time Conversion Function (TheAlgorithms#10749)
cd4633e 
* Add: Time Conversion Function

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update conversions/time_conversions.py

Co-authored-by: Christian Clauss <[email protected]>

* fix: required changes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: err

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update time_conversions.py

---------

Co-authored-by: Jeel Gajera <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Christian Clauss <[email protected]>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

@cclauss cclauss

Labels
hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeelGajera @tianyizheng02 @cclauss