Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Windows CI back #1290

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Conversation

Panquesito7
Copy link
Member

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

Signed-off-by: realstealthninja <[email protected]>
Co-authored-by: github-actions[bot] <[email protected]>
Co-authored-by: realstealthninja <[email protected]>
@Panquesito7 Panquesito7 added the enhancement New feature or request label Jul 28, 2023
Comment on lines +85 to 86
int64_t arr_empty[] = { 0 };
assert(exponential_search(arr_empty, 0, 10) == -1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might fail

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't. I tested it on Ubuntu/Gitpod and it worked fine.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see alright!

@Panquesito7
Copy link
Member Author

Will be merging in a few days if there are no objections. Ping me in case I forget.

Copy link
Member

@alexpantyukhin alexpantyukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Sep 6, 2023
@Panquesito7 Panquesito7 removed the Stale label Sep 8, 2023
@Panquesito7 Panquesito7 merged commit db3d6e2 into TheAlgorithms:master Sep 8, 2023
@Panquesito7 Panquesito7 deleted the add_windows branch September 8, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add Windows builds back
3 participants