Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDK Variable Consistency #1892

Merged
merged 7 commits into from
Jul 12, 2023
Merged

PDK Variable Consistency #1892

merged 7 commits into from
Jul 12, 2023

Conversation

donn
Copy link
Collaborator

@donn donn commented Jul 9, 2023 •
edited
Loading

~ Classified PDK variables by user modifiability
~ SYNTH_MAX_FANOUT -> Moved into PDK as MAX_FANOUT_CONSTRAINT
~ SYNTH_MAX_TRAN -> Moved into PDK as MAX_TRANSITION_CONSTRAINT
~ SYNTH_CAP_LOAD -> OUTPUT_CAP_LOAD

  • Removed DEFAULT_MAX_TRAN from PDK (unused)

Blocked by RTimothyEdwards/open_pdks#383
Resolves #1890

@donn
PDK Variable Consistency
b0538e3 
~ Classified PDK variables by user modifiability
~ `SYNTH_MAX_FANOUT` -> Moved into PDK as `MAX_FANOUT`
~ `CTS_MAX_CAP` -> `MAX_CAP`
~ `SYNTH_MAX_TRAN` -> Moved into PDK as `MAX_SLEW`
~ `SYNTH_CAP_LOAD` -> `OUTPUT_CAP_LOAD`
- Removed `DEFAULT_MAX_TRAN` from PDK (unused)
@donn donn marked this pull request as draft July 9, 2023 13:18
@donn donn requested a review from kareefardi July 9, 2023 13:18
@kareefardi
Copy link
Collaborator

kareefardi commented Jul 9, 2023 •
edited
Loading

SYNTH_MAX_FANOUT is used in ./regression_results

@kareefardi
Copy link
Collaborator

kareefardi commented Jul 9, 2023 •
edited
Loading

I think we might run into errors with SYNTH_MAX_FANOUT, SYNTH_MAX_TRAN and SYNTH_CAP_LOAD with sdc files

@donn
Copy link
Collaborator Author

donn commented Jul 9, 2023

@kareefardi Fixed both- updated the name of the first and used read_current_sdc from OL2 for the second.

@proppy proppy mentioned this pull request Jul 11, 2023
Closed
@donn donn requested a review from kareefardi July 12, 2023 10:28
@donn donn marked this pull request as ready for review July 12, 2023 11:20
@kareefardi kareefardi merged commit 2735f41 into The-OpenROAD-Project:master Jul 12, 2023
@kareefardi kareefardi mentioned this pull request Jul 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kareefardi kareefardi kareefardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PDK variables to be modified in the flow by OpenLane users
2 participants
@donn @kareefardi