Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design and add a MongoDB schema (Issue 75) - Revision #101

Merged
merged 11 commits into from
Nov 21, 2024

Conversation

Kannav02
Copy link
Collaborator

This PR will add the MongoDB schema to support the feedback data that was being used with google sheets

The following additions were made

  • function allowing to connect to the MongoDB client were established
  • new .env.example file was made to provide an example of making MongoDB URI
  • functions allowing to manipulate the MongoDB instance have been made

Apart from this a minor bug fix was also done in the frontend/utils/feedback.py file, which allowed the right passing of parameters to the functions during the runtime to avoid unexpected errors

An example of when I tried to create a mongoDB instance is here , I got the collections and the database that were being created
Screenshot 2024-11-18 at 9 16 52 PM

This PR is one of many which would lead to a complete solution of issue #75

@Kannav02
Copy link
Collaborator Author

this should be good for review now, thank you

@Kannav02 Kannav02 requested a review from luarss November 20, 2024 04:15
@luarss luarss changed the title Design and add a MongoDB schema (Issue 75) - Copy Design and add a MongoDB schema (Issue 75) - Revision Nov 20, 2024
frontend/streamlit_app.py Outdated Show resolved Hide resolved
@luarss
Copy link
Collaborator

luarss commented Nov 20, 2024

There are some linting errors in this PR. Let me fix the CI and re-trigger it.

@luarss luarss force-pushed the issue-75-1-upstream branch 2 times, most recently from 898bafd to d307b54 Compare November 20, 2024 12:31
@luarss luarss force-pushed the issue-75-1-upstream branch from d307b54 to caad676 Compare November 20, 2024 15:34
@Kannav02
Copy link
Collaborator Author

would this PR be good to merge, if yes I can start working on integrating the mongoDB functions to the main program itself

thank you!

@luarss luarss merged commit 75b486c into master Nov 21, 2024
2 checks passed
@luarss luarss deleted the issue-75-1-upstream branch November 21, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants