Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor issues on UI #96

Closed
Buuh2511 opened this issue Dec 11, 2024 · 39 comments
Closed

Fix minor issues on UI #96

Buuh2511 opened this issue Dec 11, 2024 · 39 comments
Assignees
Labels
bug Something isn't working create PR -> develop Create your branch based on develop branch and your PR should point to develop branch. Not main good first issue Good for newcomers ODBoost

Comments

@Buuh2511
Copy link
Collaborator

Buuh2511 commented Dec 11, 2024

Issue Overview

  • Fix alignment between error message and icon for every device on Login/Signup Page
  • Fix alignment between active slide and another one, need to fix width, height, border-radius (Mobile)
  • Color and text need to fix on LeaderBoard section
  • Fix component "Invitation" match with Figma, also need to cover after login/signup page (PC, Table, Mobile)]
    • /signup/welcome
    • /login/welcome

Proposed Solutions or Ideas

Pay attention to even the smallest details based on Figma

@sonkeydotcom
Copy link

Hi, can i take this

@gianalarcon gianalarcon added bug Something isn't working good first issue Good for newcomers ODBoost create PR -> develop Create your branch based on develop branch and your PR should point to develop branch. Not main labels Dec 12, 2024
@GoSTEAN
Copy link

GoSTEAN commented Dec 12, 2024

Could I be assigned to this?

@josephchimebuka
Copy link

Can I take this issue?

@Supa-mega
Copy link

Could I be assigned to this?

@zintarh
Copy link

zintarh commented Dec 12, 2024

I'd be happy to do this.

@ncoquelet
Copy link
Contributor

Hey,

I'm a dev with 20 years of XP, super comfy with TypeScript, React/Next, Dapps, Prisma, CI/CD. I ship fast and high-quality stuff. Worked with AFK and GoStarkMe, check my GitHub profile for more details (got several hackathon prizes).
Currently doing Basecamp 11.

Can I handle this task?

@obacollins-lab
Copy link

I'd love to take on this issue. can I be assigned?

@Judah04
Copy link

Judah04 commented Dec 12, 2024

@Buuh2511, I'd love to work on this.

@SimplementeCao
Copy link

Hey! I'm SimplementeCao. 👋

I have contributed before to other projects like:

  • Cairo Book
  • Starknet Book
  • Starknet Docs
  • Starknet Security Challenges Factory
  • Starkane

Can I work on this issue?

Check my OnlyDust, I've contributed to many projects: OnlyDust Profile,
and my GitHub


Plan to Solve the Issue:

  1. Analyze the codebase to understand the current structure and functionality.
  2. Review the problem description that needs to be solved by thoroughly reading the issue details.
  3. Leverage all provided resources within the issue to get a better grasp of the task at hand.
  4. If I face any challenge, I will ask questions promptly in the relevant support group or communication channel to move forward efficiently.
  5. Once resolved, I will open a PR and wait for your feedback.

Let me know if I can start working on this! 🚀


@Belloabraham121
Copy link

Hey! I'm Iteooluwakisi.
Member of Web3bridge. I have contributed before to other projects like:
• CoinSafe
• Scaffold-ETH
• BuidlGuidl
Can I work on this issue?
Plan to Solve the Issue:
Study the codebase to understand the current structure and functionality.
Understand the problem that needs to be solved by thoroughly reading the issue details.
Leverage all provided resources within the issue to get a better grasp of the task at hand.
If I encounter roadblocks, I will ask questions ASAP in the relevant group/chat to move forward effectively.
I will open a PR and wait for your feedback.

1 similar comment
@Belloabraham121
Copy link

Hey! I'm Iteooluwakisi.
Member of Web3bridge. I have contributed before to other projects like:
• CoinSafe
• Scaffold-ETH
• BuidlGuidl
Can I work on this issue?
Plan to Solve the Issue:
Study the codebase to understand the current structure and functionality.
Understand the problem that needs to be solved by thoroughly reading the issue details.
Leverage all provided resources within the issue to get a better grasp of the task at hand.
If I encounter roadblocks, I will ask questions ASAP in the relevant group/chat to move forward effectively.
I will open a PR and wait for your feedback.

@aurlic
Copy link

aurlic commented Dec 12, 2024

Hey I would love to work on this issue, if I got assigned I would go through the Figma and fix every issue according to it. I think this would be a good issue to further develop and perfect my skills. Thanks in advance !

@kcmikee
Copy link

kcmikee commented Dec 12, 2024

Hi, I'm Michael Esenwa, a proud alumni of web3bridge
I worked with React, TypeScript, including frontend interaction with smart contracts. I'm passionate about design and frontend development and excited to contribute to this project.

I value clear communication and constructive feedback, as I believe they are key to collaborative success. Happy to contribute!

@7-falseparfait
Copy link

May I handle this issue?

I am a Front-end and Smart Contract Developer with expertise in Tailwind CSS, Next.js, TypeScript, and JavaScript. I have a keen eye for detail and a strong understanding of responsive design. I would love to take on this issue, fixing the UI alignment, color, and text inconsistencies while ensuring the components match the Figma design across all devices.

@caxtonacollins
Copy link

I will love to start working on this. Please assign me.

@martinvibes
Copy link

i'm a frontend dev and blockchain dev
i would love to work on this and get it done
I’m interested in this one.
kindly assign

@wheval
Copy link

wheval commented Dec 12, 2024

Hello @Buuh2511, Is it okay if I tackle this?
I'm Wheval an experienced frontend developer.
I would ensure to fix all the UI bugs according to the Figma design.

ETA is 1 day.

@Jagadeeshftw
Copy link

Hi,
I’d love to work on this issue as I have strong experience with front-end development. Please assign this to me, and I’ll deliver an efficient and secure PR within 12-24 hours.

@greatest0falltime
Copy link

Hi,

I’d be thrilled to work on this issue as I have extensive experience with Cairo programming and building decentralized applications on StarkNet.

ETA:
I expect to have a working solution ready within the next 24 hours. Kindly let me know if I can proceed!

Looking forward to contributing!

@jahrulezfrancis
Copy link

I’ve noted the issues you mentioned, and here’s how I’ll address them. I’ll fix the alignment between the error message and the icon on the Login/Signup page to ensure it looks consistent across all devices. I’ll also adjust the alignment between the active slide and the others on mobile, making sure the width, height, and border-radius are correct. For the LeaderBoard section, I’ll refine the color and text. As for the "Invitation" component, I’ll ensure it matches the Figma design and looks good after the login/signup process, across PC, tablet, and mobile.

I’ll pay close attention to even the smallest details based on the Figma designs to ensure everything is consistent. I can have this wrapped up for you within 24 hours.

@1nonlypiece
Copy link

Hi,
I’d like to work on this issue as I have experience with Cairo and building on StarkNet, including writing and optimizing smart contracts.

ETA:
I estimate completing this task in about 12-24 hours. Let me know if I can get started!

@Storyofmujahid
Copy link

I have a keen eye for details, check my works here: https://dribbble.com/Mujaaahiid.
May I go ahead in solving this issue?

@zleypner
Copy link

Hi! I’m Anwar a Software Developer with +3 years of experience, and I would love
make a contribution to this project and contribute to the project's success.

I will fix the alignment between the error message and icon on the Login/Signup page, ensuring it is consistent across all devices. I will also adjust the width, height, and border-radius to properly align the active slide with the others on mobile.

@BrunoAmbricca
Copy link

I would like to work on this issue

@ShantelPeters
Copy link

Could I be assigned to this?

@therealemino
Copy link
Contributor

Hi, I've over 4 years professional experience working on frontend applications (React, Vue, Next, Nuxt, TS). I've gone through the repository and Figma design. I believe this is an excellent first issue for me to contribute to. Can take on this task?

@Benjtalkshow
Copy link

I am a Full Stack Developer with a strong background in blockchain and extensive experience in Next.js/React, TypeScript, and Rust. I’ve made over 49 contributions to over 17 projects in the OnlyDust ecosystem, solving complex issues and delivering efficient, scalable solutions.

I can handle this task.
ETA is 3days.

@Amarjeet325
Copy link

Can I take this issue?

@vestor-dev
Copy link

hey sir i would love to work on this issue
i'm a blockchain dev and i would love to handle this issue
assign me and i'll get to work

@tosinmoses384
Copy link

Can I take this issue?

@DuendexCR
Copy link

I'd love to give this a go.

@davedumto
Copy link

Hi. I'm David, a new open-source contributor, proficient in TypeScript, JavaScript, Tailwind CSS, and ShadCN. I can help fix UI issues by:

Aligning error messages and icons consistently across devices on the Login/Signup pages.
Fixing alignment, width, height, and border-radius for active slides (Mobile).
Correcting color and text styling in the LeaderBoard section.
Ensuring the Invitation component matches Figma designs and is responsive across devices (PC, Tablet, Mobile) on /signup/welcome and /login/welcome.
ETA 3 days

@Prosper1218
Copy link

let me fix this for you. i'll create my first PR in 50hrs.

I'm prosper Williams a frontend/Blockchain developer, Proefficient in Nextjs{typescript} and tailwind css. Paying attention to design details is a ritual for me, Let me handle this for you.
thanks!

@caxtonacollins
Copy link

I am a Full Stack Developer with two years of professional experience, specializing in web3. I have strong background in blockchain and extensive experience in Next.js/React, TypeScript, Cairo and Rust.

I will like to take care of this.

@Favvie
Copy link

Favvie commented Dec 13, 2024

Request to Work on Alignment and UI Refinements

Hello, team!

I would like to take on the task of implementing the detailed UI refinements as outlined in the issue. I'll ensure the following steps are carried out precisely:

Plan of Action:

  1. Login/Signup Page Refinements:

    • Carefully align error messages with their corresponding icons across all device types
  2. Mobile Slide Alignment:

    • Adjust styles based on the figma file of active and adjacent slides
    • Ensure smooth and consistent visual transition between slides
  3. LeaderBoard Section Updates:

    • Correct color schemes as per the original design
    • Adjust text formatting and alignment as specified in the figma file
  4. Invitation Component Implementation:

    • Ensure pixel-perfect implementation of the Invitation component to match with Figma design
    • Ensure pixel-perfect implementation for:
      • /signup/welcome page
      • /login/welcome page
    • Verify responsiveness across PC, Tablet, and Mobile devices

Approach:

  • Pixel-level attention to design details
  • Cross-device compatibility testing
  • Precise implementation following Figma specifications

I commit to delivering a high-quality implementation that meets all the specified requirements. I'll ensure careful attention to even the smallest design details.

Thank you for the opportunity to work on this task!

ETA: 48 - 72 Hours

@gianalarcon
Copy link
Collaborator

All yours @therealemino. Please test your implementation thoroughly before submitting it for review. We expect your draft PR within the next 24 hours.
Create your onw branch based on develop branch and send your PR to develop branch as well.

@therealemino
Copy link
Contributor

Thanks a lot @gianalarcon. Will get to it ASAP 🚀

@therealemino
Copy link
Contributor

Hi @gianalarcon, I've tried joining the discord community a couple of times and the link is expired (https://discord.com/invite/8A59FkYD).
I need to reach out to the admins privately to request some of the ENVs.

@gianalarcon
Copy link
Collaborator

Please join here
https://discord.gg/SC5Am6UG

therealemino added a commit to therealemino/themarquis-ui-sc that referenced this issue Dec 14, 2024
gianalarcon pushed a commit that referenced this issue Dec 20, 2024
@gianalarcon
Copy link
Collaborator

closed with #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working create PR -> develop Create your branch based on develop branch and your PR should point to develop branch. Not main good first issue Good for newcomers ODBoost
Projects
None yet
Development

No branches or pull requests