-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Peter's Submission #6
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,68 @@ | ||
# Problem Set 8.4 | ||
### The Last Time I'll Ever Have You Make Tic-Tac-Toe. I promise. 🤞🏿 | ||
This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app). | ||
|
||
## Directions | ||
Refactor your Tic-Tac-Toe app _again_. You have only one goal: implement time travel. In other words, give the user the ability to go back to previous moves. This is a [working demo](https://codepen.io/gaearon/pen/gWWZgR). | ||
## Available Scripts | ||
|
||
Here's the deal: I don't care which tools you use for this job. I want you to reach for to solutions you believer are best for the job. This means you can `useState` or `useReducer`. You can `useContext` or not. It's your choice. | ||
In the project directory, you can run: | ||
|
||
Lastly, you have a class component implementation to use for hints if you get stuck! Refactoring class components to functions is valuable practice and is also one of the objectives of this Problem Set. | ||
### `yarn start` | ||
|
||
Here's to your last ever Tic-Tac-Toe game of your Marcy Lab School career! | ||
Runs the app in the development mode.<br /> | ||
Open [http://localhost:3000](http://localhost:3000) to view it in the browser. | ||
|
||
I think. | ||
The page will reload if you make edits.<br /> | ||
You will also see any lint errors in the console. | ||
|
||
 | ||
### `yarn test` | ||
|
||
### Extra Credit | ||
* Instead of rendering buttons, use React Router so that a user can use the browser to navigate back to previous moves. | ||
Launches the test runner in the interactive watch mode.<br /> | ||
See the section about [running tests](https://facebook.github.io/create-react-app/docs/running-tests) for more information. | ||
|
||
## Due Date | ||
Submit via Pull Request by Monday, May 1 @ 9AM | ||
### `yarn build` | ||
|
||
Builds the app for production to the `build` folder.<br /> | ||
It correctly bundles React in production mode and optimizes the build for the best performance. | ||
|
||
The build is minified and the filenames include the hashes.<br /> | ||
Your app is ready to be deployed! | ||
|
||
See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information. | ||
|
||
### `yarn eject` | ||
|
||
**Note: this is a one-way operation. Once you `eject`, you can’t go back!** | ||
|
||
If you aren’t satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project. | ||
|
||
Instead, it will copy all the configuration files and the transitive dependencies (webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point you’re on your own. | ||
|
||
You don’t have to ever use `eject`. The curated feature set is suitable for small and middle deployments, and you shouldn’t feel obligated to use this feature. However we understand that this tool wouldn’t be useful if you couldn’t customize it when you are ready for it. | ||
|
||
## Learn More | ||
|
||
You can learn more in the [Create React App documentation](https://facebook.github.io/create-react-app/docs/getting-started). | ||
|
||
To learn React, check out the [React documentation](https://reactjs.org/). | ||
|
||
### Code Splitting | ||
|
||
This section has moved here: https://facebook.github.io/create-react-app/docs/code-splitting | ||
|
||
### Analyzing the Bundle Size | ||
|
||
This section has moved here: https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size | ||
|
||
### Making a Progressive Web App | ||
|
||
This section has moved here: https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app | ||
|
||
### Advanced Configuration | ||
|
||
This section has moved here: https://facebook.github.io/create-react-app/docs/advanced-configuration | ||
|
||
### Deployment | ||
|
||
This section has moved here: https://facebook.github.io/create-react-app/docs/deployment | ||
|
||
### `yarn build` fails to minify | ||
|
||
This section has moved here: https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
<head> | ||
<meta charset="utf-8" /> | ||
<link rel="icon" href="%PUBLIC_URL%/favicon.ico" /> | ||
<meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
<meta name="theme-color" content="#000000" /> | ||
<meta | ||
name="description" | ||
content="Web site created using create-react-app" | ||
/> | ||
<link rel="apple-touch-icon" href="%PUBLIC_URL%/logo192.png" /> | ||
<!-- | ||
manifest.json provides metadata used when your web app is installed on a | ||
user's mobile device or desktop. See https://developers.google.com/web/fundamentals/web-app-manifest/ | ||
--> | ||
<link rel="manifest" href="%PUBLIC_URL%/manifest.json" /> | ||
<!-- | ||
Notice the use of %PUBLIC_URL% in the tags above. | ||
It will be replaced with the URL of the `public` folder during the build. | ||
Only files inside the `public` folder can be referenced from the HTML. | ||
Unlike "/favicon.ico" or "favicon.ico", "%PUBLIC_URL%/favicon.ico" will | ||
work correctly both with client-side routing and a non-root public URL. | ||
Learn how to configure a non-root public URL by running `npm run build`. | ||
--> | ||
<title>React App</title> | ||
</head> | ||
<body> | ||
<noscript>You need to enable JavaScript to run this app.</noscript> | ||
<div id="root"></div> | ||
<!-- | ||
This HTML file is a template. | ||
If you open it directly in the browser, you will see an empty page. | ||
You can add webfonts, meta tags, or analytics to this file. | ||
The build step will place the bundled scripts into the <body> tag. | ||
To begin the development, run `npm start` or `yarn start`. | ||
To create a production bundle, use `npm run build` or `yarn build`. | ||
--> | ||
</body> | ||
</html> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
{ | ||
"short_name": "React App", | ||
"name": "Create React App Sample", | ||
"icons": [ | ||
{ | ||
"src": "favicon.ico", | ||
"sizes": "64x64 32x32 24x24 16x16", | ||
"type": "image/x-icon" | ||
}, | ||
{ | ||
"src": "logo192.png", | ||
"type": "image/png", | ||
"sizes": "192x192" | ||
}, | ||
{ | ||
"src": "logo512.png", | ||
"type": "image/png", | ||
"sizes": "512x512" | ||
} | ||
], | ||
"start_url": ".", | ||
"display": "standalone", | ||
"theme_color": "#000000", | ||
"background_color": "#ffffff" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# https://www.robotstxt.org/robotstxt.html | ||
User-agent: * | ||
Disallow: |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
body { | ||
margin: 0; | ||
padding: 20px; | ||
} | ||
|
||
.header { | ||
text-align: center; | ||
} | ||
|
||
.square { | ||
height: 80px; | ||
width: 80px; | ||
border: 1px solid black; | ||
font-size: 14px; | ||
} | ||
|
||
.board { | ||
display: flex; | ||
flex-direction: column; | ||
align-items: center; | ||
} | ||
|
||
.row { | ||
display: flex; | ||
justify-content: center; | ||
align-items: center; | ||
} | ||
|
||
.time-travel-info { | ||
display: flex; | ||
justify-content: space-around; | ||
flex-direction: column; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import React from 'react'; | ||
import './App.css'; | ||
import Board from './components/Game' | ||
import BoardContextProvider from './context/BoardContextProvider'; | ||
|
||
|
||
function App() { | ||
return ( | ||
<div className="App"> | ||
<BoardContextProvider> | ||
<Board /> | ||
</BoardContextProvider> | ||
</div> | ||
); | ||
} | ||
|
||
export default App; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import React from 'react'; | ||
import { render } from '@testing-library/react'; | ||
import App from './App'; | ||
|
||
test('renders learn react link', () => { | ||
const { getByText } = render(<App />); | ||
const linkElement = getByText(/learn react/i); | ||
expect(linkElement).toBeInTheDocument(); | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,99 @@ | ||
import React from 'react' | ||
import Square from './Square'; | ||
import BoardContext from '../context/BoardContext' | ||
|
||
function Board(props) { | ||
const { board, setBoard, turn, setTurn, history, setHistory } = useContext(BoardContext); | ||
|
||
function declareWinner(board) { | ||
const winningCombos = [ | ||
[3, 4, 5], | ||
[0, 1, 2], | ||
[0, 3, 6], | ||
[2, 5, 8], | ||
[1, 4, 7], | ||
[0, 4, 8], | ||
[2, 4, 6], | ||
[6, 7, 8], | ||
]; | ||
|
||
function threeInARow() { | ||
for (let i = 0; i < winningCombos.length; i++) { | ||
const [first, second, third] = winningCombos[i]; | ||
// When you get 3 in a row, in any direction. | ||
if (board[first] && board[first] === board[second] && board[first] === board[third]) { | ||
return board[first]; | ||
} | ||
} | ||
return null; | ||
} | ||
threeInARow() | ||
}; | ||
|
||
const winner = declareWinner(board); | ||
|
||
// Check for winner, every move. | ||
let status = null; | ||
if (winner) { | ||
status = `${winner} WON THE GAME!`; | ||
}; | ||
|
||
function timeTravel(turn) { | ||
const boardInHistory = [...history]; | ||
setBoard(boardInHistory[turn]); | ||
} | ||
|
||
function clickHandler(i) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No right or wrong answer here, but I think you could make an argument that this logic could fit nicely on the context. Instead of the context providing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. One other upside to that approach is that the |
||
if (!winner && !board[i]) { | ||
const newBoard = [...board]; | ||
const newHistory = [...history]; | ||
newBoard[i] = turn; | ||
setBoard(newBoard); | ||
setHistory(newHistory); | ||
setTurn((turn === 'X') ? 'O' : 'X'); | ||
}; | ||
} | ||
|
||
const moves = history.forEach(square, index => { // use map instead ? | ||
const steps = index ? `Go to move ${index}` : 'Restart Game'; | ||
return ( | ||
<li key={index}> | ||
<button onClick={() => timeTravel(index)}>{steps}</button> | ||
</li> | ||
) | ||
}); | ||
|
||
return ( | ||
<div className='game'> | ||
<div className="board"> | ||
<h4>Currently player {turn}'s turn. Make your move.</h4> | ||
<h3>{status}</h3> | ||
<h3>{moves}</h3> | ||
|
||
<div className="row board-row"> | ||
<Square onClick={() => clickHandler(0)} value={board[0]} /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can shorten this up a bit by using the {_.chunk(board, 3).map(row => (
<div className="row board-row">{row.map((cell, i) => <Square onClick={() => clickHandler(i)} value={cell} }</div>
))} |
||
<Square onClick={() => clickHandler(1)} value={board[1]} /> | ||
<Square onClick={() => clickHandler(2)} value={board[2]} /> | ||
</div> | ||
|
||
<div className="row board-row"> | ||
<Square onClick={() => clickHandler(3)} value={board[3]} /> | ||
<Square onClick={() => clickHandler(4)} value={board[4]} /> | ||
<Square onClick={() => clickHandler(5)} value={board[5]} /> | ||
</div> | ||
|
||
<div className="row board-row"> | ||
<Square onClick={() => clickHandler(6)} value={board[6]} /> | ||
<Square onClick={() => clickHandler(7)} value={board[7]} /> | ||
<Square onClick={() => clickHandler(8)} value={board[8]} /> | ||
</div> | ||
</div> | ||
<div className='game-data'> | ||
<div>{status}</div> | ||
<ol>{moves}</ol> | ||
</div> | ||
</div> | ||
); | ||
} | ||
|
||
export default Board |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import React from 'react' | ||
|
||
function Square(props) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. One small note: you can use object destructuring if you like to avoid needing to call |
||
return ( | ||
<button className="button" onClick={props.click}>{props.value}</button> | ||
); | ||
} | ||
|
||
export default Square |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import React, {useContext} from 'react' | ||
|
||
const BoardContext = React.createContext({}); | ||
|
||
export default BoardContext |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
import React, { useState } from "react"; | ||
import BoardContext from "./BoardContext"; | ||
|
||
export const BoardContextProvider = ({ children }) => { | ||
const [board, setBoard] = useState(new Array(9).fill("")); | ||
const [turn, setTurn] = useState('X'); | ||
const [history, setHistory] = useState([]); | ||
const value = { | ||
board, | ||
setBoard, | ||
turn, | ||
setTurn, | ||
history, | ||
setHistory, | ||
}; | ||
return ( | ||
<BoardContext.Provider value={value}> | ||
{children} | ||
</BoardContext.Provider> | ||
); | ||
|
||
}; | ||
|
||
export default BoardContextProvider; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
body { | ||
margin: 0; | ||
font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', 'Roboto', 'Oxygen', | ||
'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', | ||
sans-serif; | ||
-webkit-font-smoothing: antialiased; | ||
-moz-osx-font-smoothing: grayscale; | ||
} | ||
|
||
code { | ||
font-family: source-code-pro, Menlo, Monaco, Consolas, 'Courier New', | ||
monospace; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import React from 'react'; | ||
import ReactDOM from 'react-dom'; | ||
import './index.css'; | ||
import App from './App'; | ||
import * as serviceWorker from './serviceWorker'; | ||
|
||
ReactDOM.render( | ||
<React.StrictMode> | ||
<App /> | ||
</React.StrictMode>, | ||
document.getElementById('root') | ||
); | ||
|
||
// If you want your app to work offline and load faster, you can change | ||
// unregister() to register() below. Note this comes with some pitfalls. | ||
// Learn more about service workers: https://bit.ly/CRA-PWA | ||
serviceWorker.unregister(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need a
return
statement here to either returnnull
or the winner.